| Message ID | 1416199491-4841-1-git-send-email-a.kesavan@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 17, 2014 at 10:14:51AM +0530, Abhilash Kesavan wrote: > From: Pankaj Dubey <pankaj.dubey@samsung.com> > > Exynos7 has a similar serial controller to that present in older Samsung > SoCs. To re-use the existing serial driver on Exynos7 we need to have > SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not > possible because these symbols are dependent on PLAT_SAMSUNG which is > not present for the ARMv8 based exynos7. > > Change the dependency of these symbols from PLAT_SAMSUNG to the serial > driver thus making it available on exynos7. As the existing platform > specific code making use of these symbols is related to uart driver this > change in dependency should not cause any issues. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/18/14 03:59, Greg KH wrote: > On Mon, Nov 17, 2014 at 10:14:51AM +0530, Abhilash Kesavan wrote: >> From: Pankaj Dubey <pankaj.dubey@samsung.com> >> >> Exynos7 has a similar serial controller to that present in older Samsung >> SoCs. To re-use the existing serial driver on Exynos7 we need to have >> SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not >> possible because these symbols are dependent on PLAT_SAMSUNG which is >> not present for the ARMv8 based exynos7. >> >> Change the dependency of these symbols from PLAT_SAMSUNG to the serial >> driver thus making it available on exynos7. As the existing platform >> specific code making use of these symbols is related to uart driver this >> change in dependency should not cause any issues. >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> --- > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Greg, thanks for your ack on this. Abhilash, I can't find the original patch in my mailbox, can you please re-send to me with adding Greg's ack? Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Kukjin, On Wed, Nov 19, 2014 at 12:58 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > On 11/18/14 03:59, Greg KH wrote: >> On Mon, Nov 17, 2014 at 10:14:51AM +0530, Abhilash Kesavan wrote: >>> From: Pankaj Dubey <pankaj.dubey@samsung.com> >>> >>> Exynos7 has a similar serial controller to that present in older Samsung >>> SoCs. To re-use the existing serial driver on Exynos7 we need to have >>> SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not >>> possible because these symbols are dependent on PLAT_SAMSUNG which is >>> not present for the ARMv8 based exynos7. >>> >>> Change the dependency of these symbols from PLAT_SAMSUNG to the serial >>> driver thus making it available on exynos7. As the existing platform >>> specific code making use of these symbols is related to uart driver this >>> change in dependency should not cause any issues. >>> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> --- >> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> > Greg, thanks for your ack on this. > > Abhilash, > > I can't find the original patch in my mailbox, can you please re-send to > me with adding Greg's ack? Will send it you with Greg's Ack. Thanks, Abhilash > > Thanks, > Kukjin > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index e71a28b..d0ce88c 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -249,14 +249,14 @@ config SERIAL_SAMSUNG config SERIAL_SAMSUNG_UARTS_4 bool - depends on PLAT_SAMSUNG + depends on SERIAL_SAMSUNG default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442) help Internal node for the common case of 4 Samsung compatible UARTs config SERIAL_SAMSUNG_UARTS int - depends on PLAT_SAMSUNG + depends on SERIAL_SAMSUNG default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416 default 3 help