| Message ID | 1418797339-27877-1-git-send-email-tony.kn@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Gentle Reminder. Thanks Tony > -----Original Message----- > From: Tony K Nadackal [mailto:tony.kn@samsung.com] > Sent: Wednesday, December 17, 2014 11:52 AM > To: linux-media@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org > Cc: mchehab@osg.samsung.com; j.anaszewski@samsung.com; > kgene@kernel.org; k.debski@samsung.com; s.nawrocki@samsung.com; > bhushan.r@samsung.com; Tony K Nadackal > Subject: [PATCH] [media] s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset > function > > Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared on > software reset. These bits need to be cleared explicitly. > > Signed-off-by: Tony K Nadackal <tony.kn@samsung.com> > --- > This patch is created and tested on top of linux-next-20141210. > It can be cleanly applied on media-next and kgene/for-next. > > > drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > index ab6d6f43..e53f13a 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > @@ -21,6 +21,10 @@ void exynos4_jpeg_sw_reset(void __iomem *base) > unsigned int reg; > > reg = readl(base + EXYNOS4_JPEG_CNTL_REG); > + writel(reg & ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE), > + base + EXYNOS4_JPEG_CNTL_REG); > + > + reg = readl(base + EXYNOS4_JPEG_CNTL_REG); > writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + > EXYNOS4_JPEG_CNTL_REG); > > udelay(100); > -- > 2.2.0 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 17/12/14 07:22, Tony K Nadackal wrote: > Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared > on software reset. These bits need to be cleared explicitly. > > Signed-off-by: Tony K Nadackal <tony.kn@samsung.com> > --- > This patch is created and tested on top of linux-next-20141210. > It can be cleanly applied on media-next and kgene/for-next. > > > drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > index ab6d6f43..e53f13a 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > @@ -21,6 +21,10 @@ void exynos4_jpeg_sw_reset(void __iomem *base) > unsigned int reg; > > reg = readl(base + EXYNOS4_JPEG_CNTL_REG); > + writel(reg & ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE), > + base + EXYNOS4_JPEG_CNTL_REG); > + > + reg = readl(base + EXYNOS4_JPEG_CNTL_REG); Do we really need the second read? Wouldn't it also work as below ? reg = readl(base + EXYNOS4_JPEG_CNTL_REG); + reg &= ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE); + writel(reg, base + EXYNOS4_JPEG_CNTL_REG); ? > writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + EXYNOS4_JPEG_CNTL_REG); > > udelay(100); -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c index ab6d6f43..e53f13a 100644 --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c +++ b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c @@ -21,6 +21,10 @@ void exynos4_jpeg_sw_reset(void __iomem *base) unsigned int reg; reg = readl(base + EXYNOS4_JPEG_CNTL_REG); + writel(reg & ~(EXYNOS4_DEC_MODE | EXYNOS4_ENC_MODE), + base + EXYNOS4_JPEG_CNTL_REG); + + reg = readl(base + EXYNOS4_JPEG_CNTL_REG); writel(reg & ~EXYNOS4_SOFT_RESET_HI, base + EXYNOS4_JPEG_CNTL_REG); udelay(100);
Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared on software reset. These bits need to be cleared explicitly. Signed-off-by: Tony K Nadackal <tony.kn@samsung.com> --- This patch is created and tested on top of linux-next-20141210. It can be cleanly applied on media-next and kgene/for-next. drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 ++++ 1 file changed, 4 insertions(+)