From patchwork Mon Feb 2 09:47:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 5760301 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B3C0F9F302 for ; Mon, 2 Feb 2015 09:48:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CDFDC20218 for ; Mon, 2 Feb 2015 09:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEDB7201F5 for ; Mon, 2 Feb 2015 09:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372AbbBBJsI (ORCPT ); Mon, 2 Feb 2015 04:48:08 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:34502 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753550AbbBBJsH (ORCPT ); Mon, 2 Feb 2015 04:48:07 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJ5007QV22TL280@mailout4.w1.samsung.com>; Mon, 02 Feb 2015 09:52:05 +0000 (GMT) X-AuditID: cbfec7f5-b7fc86d0000066b7-1f-54cf47427835 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id C8.64.26295.2474FC45; Mon, 02 Feb 2015 09:45:38 +0000 (GMT) Content-transfer-encoding: 8BIT Received: from amdc1339.digital.local ([106.116.147.30]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NJ500G8G1W14H10@eusync3.samsung.com>; Mon, 02 Feb 2015 09:48:04 +0000 (GMT) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org Cc: Marek Szyprowski , Alim Akhtar , thomas.ab@samsung.com, Tomasz Figa , Kukjin Kim , Greg Kroah-Hartman Subject: [PATCH] serial: samsung: earlycon support depends on CONFIG_SERIAL_SAMSUNG_CONSOLE Date: Mon, 02 Feb 2015 10:47:35 +0100 Message-id: <1422870455-19581-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsVy+t/xq7pO7udDDJ53a1g8mLeNzaJ58Xo2 i/7Hr5ktZpzfx2RxZnEvu8XaI3fZLTqWMVqs2vWH0YHDY+esu+wem1Z1snnsn7uG3aNvyypG j8+b5AJYo7hsUlJzMstSi/TtErgyvnbcZC9YKlVx/bNIA+M58S5GDg4JAROJCZuYuhg5gUwx iQv31rN1MXJxCAksZZToWrSIBSTBKyAo8WPyPRaQemYBeYkjl7JBwswC6hKT5i1ihqjvY5Jo mtDBCJJgEzCU6HrbxQZiiwg4S8w+u5AJpIhZ4AWjxOkfB8CGCgvESqxu7WIFsVkEVCU+Xv7O BrHMQ6Jj4V92iIvkJP6/XME0gZFvFpI7ZiHcMQvJHQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al 6yXn525ihATu1x2MS49ZHWIU4GBU4uF9wH0uRIg1say4MvcQowQHs5IIr4bF+RAh3pTEyqrU ovz4otKc1OJDjEwcnFINjLN783Y++yH3o+V6ocxNwa3M23MrnvQc1PC8e2L/+sl3z9uEiUcw sCnuspW24vp+tUSs3sFeZFL+c8M5iX/j3SZsVuHrX/Ra0P6RfKyOXOW64H1mOkuP6JrEih84 fp5prpdQW4ecu5hO43upRY8fR6ix5azQKJo3dcneH7VR1RZ/j9kpbgrdqcRSnJFoqMVcVJwI AHGx5TA6AgAA Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP EarlyCon support depends on serial console infrastructure, so the code implementing it should depend on CONFIG_SERIAL_SAMSUNG_CONSOLE. This patch fixes the following build break: CC [M] drivers/tty/serial/samsung.o drivers/tty/serial/samsung.c:2468:1: error: expected declaration specifiers or ‘...’ before string constant drivers/tty/serial/samsung.c:2468:1: error: expected declaration specifiers or ‘...’ before ‘s3c2410_setup_earlycon’ drivers/tty/serial/samsung.c:2487:1: error: expected declaration specifiers or ‘...’ before string constant drivers/tty/serial/samsung.c:2487:1: error: expected declaration specifiers or ‘...’ before ‘s3c2412_setup_earlycon’ drivers/tty/serial/samsung.c:2488:1: error: expected declaration specifiers or ‘...’ before string constant drivers/tty/serial/samsung.c:2488:1: error: expected declaration specifiers or ‘...’ before ‘s3c2440_setup_earlycon’ drivers/tty/serial/samsung.c:2489:1: error: expected declaration specifiers or ‘...’ before string constant drivers/tty/serial/samsung.c:2489:1: error: expected declaration specifiers or ‘...’ before ‘s3c6400_setup_earlycon’ drivers/tty/serial/samsung.c:2506:1: error: expected declaration specifiers or ‘...’ before string constant drivers/tty/serial/samsung.c:2506:1: error: expected declaration specifiers or ‘...’ before ‘s5pv210_setup_earlycon’ drivers/tty/serial/samsung.c:2507:1: error: expected declaration specifiers or ‘...’ before string constant drivers/tty/serial/samsung.c:2507:1: error: expected declaration specifiers or ‘...’ before ‘exynos4210_setup_earlycon’ drivers/tty/serial/samsung.c:2468:1: warning: ‘s3c2410_setup_earlycon’ defined but not used [-Wunused-function] drivers/tty/serial/samsung.c:2487:1: warning: ‘s3c2412_setup_earlycon’ defined but not used [-Wunused-function] drivers/tty/serial/samsung.c:2488:1: warning: ‘s3c2440_setup_earlycon’ defined but not used [-Wunused-function] drivers/tty/serial/samsung.c:2489:1: warning: ‘s3c6400_setup_earlycon’ defined but not used [-Wunused-function] drivers/tty/serial/samsung.c:2506:1: warning: ‘s5pv210_setup_earlycon’ defined but not used [-Wunused-function] drivers/tty/serial/samsung.c:2507:1: warning: ‘exynos4210_setup_earlycon’ defined but not used [-Wunused-function] make[3]: *** [drivers/tty/serial/samsung.o] Error 1 Reported-by: kbuild test robot Signed-off-by: Marek Szyprowski --- drivers/tty/serial/samsung.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index a6bef8dcdc3c..bb73897809a1 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -2403,6 +2403,7 @@ static struct platform_driver samsung_serial_driver = { module_platform_driver(samsung_serial_driver); +#ifdef CONFIG_SERIAL_SAMSUNG_CONSOLE /* * Early console. */ @@ -2505,6 +2506,7 @@ OF_EARLYCON_DECLARE(exynos4210, "samsung,exynos4210-uart", s5pv210_early_console_setup); EARLYCON_DECLARE(s5pv210, s5pv210_early_console_setup); EARLYCON_DECLARE(exynos4210, s5pv210_early_console_setup); +#endif MODULE_ALIAS("platform:samsung-uart"); MODULE_DESCRIPTION("Samsung SoC Serial port driver");