From patchwork Tue Feb 3 11:06:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 5767701 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 53FBE9F269 for ; Tue, 3 Feb 2015 11:07:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6C756204D8 for ; Tue, 3 Feb 2015 11:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8800020498 for ; Tue, 3 Feb 2015 11:07:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933632AbbBCLHE (ORCPT ); Tue, 3 Feb 2015 06:07:04 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:32692 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933269AbbBCLG7 (ORCPT ); Tue, 3 Feb 2015 06:06:59 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJ7004XZ0E74O80@mailout2.w1.samsung.com>; Tue, 03 Feb 2015 11:10:55 +0000 (GMT) X-AuditID: cbfec7f5-b7fc86d0000066b7-54-54d0ab39153f Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 63.2D.26295.93BA0D45; Tue, 03 Feb 2015 11:04:25 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NJ700KZ707C4X10@eusync1.samsung.com>; Tue, 03 Feb 2015 11:06:51 +0000 (GMT) From: Krzysztof Kozlowski To: Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Date: Tue, 03 Feb 2015 12:06:39 +0100 Message-id: <1422961601-7087-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGJMWRmVeSWpSXmKPExsVy+t/xy7qWqy+EGNyapG3x+oWhRf/j18wW mx5fY7W4vGsOm8WM8/uYLG5f5nVg82hp7mHz2LSqk81j85J6j74tqxg9Pm+SC2CN4rJJSc3J LEst0rdL4Mr4e7K64L1Axb8v/1kaGLfydTFyckgImEgsmfKJBcIWk7hwbz1bFyMXh5DAUkaJ p/e/s0A4fUwSix5+BKtiEzCW2Lx8CViViMBmRon+xt2sIAlmAUOJn+/+sIPYwgIhEsfvPACz WQRUJWa+mMsIYvMKuEl0H7rFCrFOTuLkscmsExi5FzAyrGIUTS1NLihOSs810itOzC0uzUvX S87P3cQICYuvOxiXHrM6xCjAwajEw7vz6/kQIdbEsuLK3EOMEhzMSiK86csvhAjxpiRWVqUW 5ccXleakFh9iZOLglGpgLN19/9zbC7tDudeeeyrjJ5tS88zMy0EzxMZv9jkVrVzur47es9jq ZrC5TH7mypRu4GwnMLtJ4dZ2fkXTnIO+jvXTFiRM2FZ97yznMclDH8Vl160w5U/w38gYNNHF +LvLlNPcH98cevDss9fK+SkuBw7dsfJ54eT6YsrzZqlFD8WOvXlw4/LLJ0osxRmJhlrMRcWJ ALchfXTpAQAA Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs' and 'exynos5420_release_ret_regs' are not exported nor used outside of suspend.c file. Make them static. This fixes following sparse warnings: arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static? arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static? arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Add static to 'exynos3250_release_ret_regs' (suggested by Kukjin). --- arch/arm/mach-exynos/suspend.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index 82e6b6fba23f..77cc39bdad47 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -75,7 +75,7 @@ struct exynos_pm_data { int (*cpu_suspend)(unsigned long); }; -struct exynos_pm_data *pm_data; +static struct exynos_pm_data *pm_data; static int exynos5420_cpu_state; static unsigned int exynos_pmu_spare3; @@ -104,7 +104,7 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = { { /* sentinel */ }, }; -unsigned int exynos_release_ret_regs[] = { +static unsigned int exynos_release_ret_regs[] = { S5P_PAD_RET_MAUDIO_OPTION, S5P_PAD_RET_GPIO_OPTION, S5P_PAD_RET_UART_OPTION, @@ -115,7 +115,7 @@ unsigned int exynos_release_ret_regs[] = { REG_TABLE_END, }; -unsigned int exynos3250_release_ret_regs[] = { +static unsigned int exynos3250_release_ret_regs[] = { S5P_PAD_RET_MAUDIO_OPTION, S5P_PAD_RET_GPIO_OPTION, S5P_PAD_RET_UART_OPTION, @@ -128,7 +128,7 @@ unsigned int exynos3250_release_ret_regs[] = { REG_TABLE_END, }; -unsigned int exynos5420_release_ret_regs[] = { +static unsigned int exynos5420_release_ret_regs[] = { EXYNOS_PAD_RET_DRAM_OPTION, EXYNOS_PAD_RET_MAUDIO_OPTION, EXYNOS_PAD_RET_JTAG_OPTION,