From patchwork Sat Feb 7 11:53:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 5796021 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 504059F336 for ; Sat, 7 Feb 2015 11:53:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4BA7920173 for ; Sat, 7 Feb 2015 11:53:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33697201EF for ; Sat, 7 Feb 2015 11:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755795AbbBGLxQ (ORCPT ); Sat, 7 Feb 2015 06:53:16 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:52066 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755278AbbBGLxN (ORCPT ); Sat, 7 Feb 2015 06:53:13 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJE006OUH0LGG90@mailout1.samsung.com>; Sat, 07 Feb 2015 20:53:10 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.115]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 5C.7B.11124.5ACF5D45; Sat, 07 Feb 2015 20:53:09 +0900 (KST) X-AuditID: cbfee68e-f79b46d000002b74-5e-54d5fca54477 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 93.AB.09430.5ACF5D45; Sat, 07 Feb 2015 20:53:09 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.252.83.67]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NJE00IYBH0LPD80@mmp1.samsung.com>; Sat, 07 Feb 2015 20:53:09 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, a.hajda@samsung.com, Inki Dae Subject: [PATCH 1/4] drm/exynos: dsim: fix to control mipi phy register Date: Sat, 07 Feb 2015 20:53:05 +0900 Message-id: <1423309988-11793-2-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1423309988-11793-1-git-send-email-inki.dae@samsung.com> References: <1423309988-11793-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42JZI2JSrLv0z9UQg1frzCxurTvHatF77iST xfwjQNaVr+/ZLPrfLGS1OPdqJaPFpPsTWCx6F1xls5hxfh+TxdLrF5ksJkxfy2LRuvcIuwOP x5p5axg9Lvf1MnmsXP6FzWPTqk42j+3fHrB63O8+zuTRt2UVo8fnTXIBHFFcNimpOZllqUX6 dglcGRfvLmUpaDKtuN63gqmB8blWFyMHh4SAicT3pWJdjJxAppjEhXvr2boYuTiEBJYySizs n8EEkTCR+LOwlQkisYhR4kbPPkYIp5tJorH9NjtIFZuAqsTEFffZQGwRgWCJSadusoIUMQu8 ZpS49+8IM0hCWMBd4v6n82BFLEANTVfbWEBsXgEXiZeX7jNBnKQgMWeSDUiYU8BVYvbUFkYQ Wwio5GD3ThaQmRIC19gl7k8/xwIxR0Di2+RDLBC9shKbDjBDXC0pcXDFDZYJjMILGBlWMYqm FiQXFCelFxnpFSfmFpfmpesl5+duYgTGzel/z/p2MN48YH2IUYCDUYmHd0Ly1RAh1sSy4src Q4ymQBsmMkuJJucDozOvJN7Q2MzIwtTE1NjI3NJMSZw3QepnsJBAemJJanZqakFqUXxRaU5q 8SFGJg5OqQZGtxWR0dLvcus+bl+7M38B92Ve/htFmxvmPRf/wnbp22b7zgdFAhOlS9evu+hs V270Y6neDa8FqmdVzTL4ZJbuC7DY25lf6+ZxKmHhvAc77N3rj21NXW4k2/tmlfcD68yElxI+ +TJXr/Ecruna9ItrW5Den9nXd98y0zw063eQYOT7lu/CU154KrEUZyQaajEXFScCALQraKSW AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jAd2lf66GGCzs07a4te4cq0XvuZNM FvOPAFlXvr5ns+h/s5DV4tyrlYwWk+5PYLHoXXCVzWLG+X1MFkuvX2SymDB9LYtF694j7A48 HmvmrWH0uNzXy+SxcvkXNo9NqzrZPLZ/e8Dqcb/7OJNH35ZVjB6fN8kFcEQ1MNpkpCampBYp pOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAN2rpFCWmFMKFApILC5W 0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcy4eHcpS0GTacX1vhVMDYzPtboYOTkkBEwk/ixs ZYKwxSQu3FvP1sXIxSEksIhR4kbPPkYIp5tJorH9NjtIFZuAqsTEFffZQGwRgWCJSadusoIU MQu8ZpS49+8IM0hCWMBd4v6n82BFLEANTVfbWEBsXgEXiZeX7gOt4wBapyAxZ5INSJhTwFVi 9tQWRhBbCKjkYPdOlgmMvAsYGVYxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525iBMflM+kdjKsa LA4xCnAwKvHwTki+GiLEmlhWXJl7iFGCg1lJhHfbTqAQb0piZVVqUX58UWlOavEhRlOgoyYy S4km5wNTRl5JvKGxiZmRpZG5oYWRsbmSOK+SfVuIkEB6YklqdmpqQWoRTB8TB6dUA6P4L/2C pE/nPp1y88pW3xp9xv/Hly8XpioeOb3KOyCf+0c41xf+M3dk56+p6JKP6pp52Ee5sKNzQqSk u8apY3nZi8/pbb531Y7JLvy/jmxCdXzT7Zw+zaMOE+5LL516+CTbXRE5w7zbSYIpga6b//8u uCK0arW2xN34xPe2x2rPtcn52Hzid1ZiKc5INNRiLipOBACsYu/04QIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the issue that the try to get a phy object is failed to enable mipi phy. System and power management unit registers should be controlled by syscon framework. So this patch removes existing phy framework based codes and adds syscon support instead. However, we should support legacy device tree binding so consider the legacy binding for compatibility. In addition, we need to remove below device node and relevant properties, mipi_phy: video-phy@10020710 { compatible = "samsung,s5pv210-mipi-video-phy"; reg = <0x10020710 8>; #phy-cells = <1>; }; Now camera device node uses mipi_phy node relevant properties like below, camera { ... csis_0: csis@11880000 { ... phys = <&mipi_phy 0>; phy-names = "csis"; ... }; csis_1: csis@11890000 { ... phys = <&mipi_phy 2>; phy-names = "csis"; ... }; ... }; With above, we will find below message while booting, can't request region for resource [mem 0x10020710-0x10020717] Signed-off-by: Inki Dae --- .../devicetree/bindings/video/exynos_dsim.txt | 9 ++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 54 ++++++++++++++++++-- 2 files changed, 56 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/video/exynos_dsim.txt b/Documentation/devicetree/bindings/video/exynos_dsim.txt index ca2b4aa..dec3b55 100644 --- a/Documentation/devicetree/bindings/video/exynos_dsim.txt +++ b/Documentation/devicetree/bindings/video/exynos_dsim.txt @@ -11,15 +11,18 @@ Required properties: - clocks: list of clock specifiers, must contain an entry for each required entry in clock-names - clock-names: should include "bus_clk"and "pll_clk" entries - - phys: list of phy specifiers, must contain an entry for each required - entry in phy-names - - phy-names: should include "dsim" entry + - samsung,pmureg: handle to syscon used to control the PMU registers - vddcore-supply: MIPI DSIM Core voltage supply (e.g. 1.1V) - vddio-supply: MIPI DSIM I/O and PLL voltage supply (e.g. 1.8V) - samsung,pll-clock-frequency: specifies frequency of the "pll_clk" clock - #address-cells, #size-cells: should be set respectively to <1> and <0> according to DSI host bindings (see MIPI DSI bindings [1]) +Deprecated properties for MIPI DSI Master: + - phys: list of phy specifiers, must contain an entry for each required + entry in phy-names (Deprecated) + - phy-names: should include "dsim" entry (Deprecated) + Optional properties: - samsung,power-domain: a phandle to DSIM power domain node diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 05fe93d..38b025e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -23,6 +23,8 @@ #include #include #include +#include +#include #include