| Message ID | 1425558488-7039-1-git-send-email-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Marek, Patch looks good to me. Just a small comment below so feel free to add my Reviewed by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> On Thu, Mar 5, 2015 at 1:28 PM, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > This patch adds nodes for hardware JPEG codec found in Exynos 4210 and > 4x12 SoCs. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++ > arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++ > 2 files changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 77ea547..1bd630a 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -685,6 +685,15 @@ > #include "exynos4412-tmu-sensor-conf.dtsi" > }; > > + jpeg-codec@11840000 { > + compatible = "samsung,exynos4210-jpeg"; > + reg = <0x11840000 0x1000>; > + interrupts = <0 88 0>; > + clocks = <&clock CLK_JPEG>; > + clock-names = "jpeg"; > + samsung,power-domain = <&pd_cam>; Shouldn't you use the generic "power-domains" property here instead? Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, On 2015-03-05 13:41, Javier Martinez Canillas wrote: > Hello Marek, > > Patch looks good to me. Just a small comment below so feel free to add my > > Reviewed by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > > On Thu, Mar 5, 2015 at 1:28 PM, Marek Szyprowski > <m.szyprowski@samsung.com> wrote: >> This patch adds nodes for hardware JPEG codec found in Exynos 4210 and >> 4x12 SoCs. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++ >> arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >> index 77ea547..1bd630a 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi >> @@ -685,6 +685,15 @@ >> #include "exynos4412-tmu-sensor-conf.dtsi" >> }; >> >> + jpeg-codec@11840000 { >> + compatible = "samsung,exynos4210-jpeg"; >> + reg = <0x11840000 0x1000>; >> + interrupts = <0 88 0>; >> + clocks = <&clock CLK_JPEG>; >> + clock-names = "jpeg"; >> + samsung,power-domain = <&pd_cam>; > Shouldn't you use the generic "power-domains" property here instead? Definitely. I've missed that after rebasing my local tree... Best regards
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 77ea547..1bd630a 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -685,6 +685,15 @@ #include "exynos4412-tmu-sensor-conf.dtsi" }; + jpeg-codec@11840000 { + compatible = "samsung,exynos4210-jpeg"; + reg = <0x11840000 0x1000>; + interrupts = <0 88 0>; + clocks = <&clock CLK_JPEG>; + clock-names = "jpeg"; + samsung,power-domain = <&pd_cam>; + }; + hdmi: hdmi@12D00000 { compatible = "samsung,exynos4210-hdmi"; reg = <0x12D00000 0x70000>; diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi index 6a6abe1..72b9a1d 100644 --- a/arch/arm/boot/dts/exynos4x12.dtsi +++ b/arch/arm/boot/dts/exynos4x12.dtsi @@ -299,6 +299,10 @@ status = "disabled"; }; + jpeg-codec@11840000 { + compatible = "samsung,exynos4212-jpeg"; + }; + hdmi: hdmi@12D00000 { compatible = "samsung,exynos4212-hdmi"; };
This patch adds nodes for hardware JPEG codec found in Exynos 4210 and 4x12 SoCs. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++ arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++ 2 files changed, 13 insertions(+)