diff mbox

phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path

Message ID 1426032383.5707.1.camel@phoenix (mailing list archive)
State New, archived
Headers show

Commit Message

Axel Lin March 11, 2015, 12:06 a.m. UTC
Remove the second lock on non-regmap path.

Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/phy/phy-exynos-mipi-video.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kishon Vijay Abraham I March 12, 2015, 5:32 a.m. UTC | #1
On Wednesday 11 March 2015 05:36 AM, Axel Lin wrote:
> Remove the second lock on non-regmap path.
>
> Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations)
> Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

merged after squashing it with the original patch.

Thanks
Kishon
> ---
>   drivers/phy/phy-exynos-mipi-video.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
> index 8d6d117..df7519a 100644
> --- a/drivers/phy/phy-exynos-mipi-video.c
> +++ b/drivers/phy/phy-exynos-mipi-video.c
> @@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state,
>   	} else {
>   		addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
>
> -		spin_lock(&state->slock);
>   		val = readl(addr);
>   		if (on)
>   			val |= reset;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
index 8d6d117..df7519a 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -75,7 +75,6 @@  static int __set_phy_state(struct exynos_mipi_video_phy *state,
 	} else {
 		addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2);
 
-		spin_lock(&state->slock);
 		val = readl(addr);
 		if (on)
 			val |= reset;