From patchwork Wed Mar 11 00:06:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 5981231 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EA4E19F380 for ; Wed, 11 Mar 2015 00:06:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 13E04202DD for ; Wed, 11 Mar 2015 00:06:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6483202EB for ; Wed, 11 Mar 2015 00:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbbCKAG3 (ORCPT ); Tue, 10 Mar 2015 20:06:29 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:41423 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbCKAG2 (ORCPT ); Tue, 10 Mar 2015 20:06:28 -0400 Received: by pdjy10 with SMTP id y10so6228133pdj.8 for ; Tue, 10 Mar 2015 17:06:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=rjk+f7CowfzxS0S3WVrhx+3+YCAfwytsMNp1lLJIQ8g=; b=B74xlH/ERelVpZAKUw7Lo7hxw4MOHoWFx+sUnSX3fDydtv5Hi3mMAb7SarHTiPYT15 brUgUVTLPb+MAFaWtGn47FVk9yPBYtMCgSwktxny1USUXdbf6FyM5lwIW+tmJY/fUWII 4jmW+LIdmiZNI5mfJLu1adVptRrea+kMJoo2pnwINaqdtTWni8lvRbL2Z59n47ThwavL 1YeU+y99Hx+2QfXfZmjM4fE1U46//k9p2I43oLNFYRMGpqqXyOx/hrnwGg5hbCvCPJSw nFRZAo2SNKidJM/7DCqSJy5NiDAGda6X72eMtz5a+iZ6jcMkBUkDY78hL78KFmpaRmLF nYzw== X-Gm-Message-State: ALoCoQmqpYmqe+UMgqCIHve0KV+t9arOK1oZj8RdYdOPuxH4cPcGpruheO/zL0KqExrZ9anhTBY/ X-Received: by 10.70.34.79 with SMTP id x15mr32441653pdi.6.1426032388356; Tue, 10 Mar 2015 17:06:28 -0700 (PDT) Received: from [192.168.0.104] (36-239-207-225.dynamic-ip.hinet.net. [36.239.207.225]) by mx.google.com with ESMTPSA id dt10sm2742244pdb.82.2015.03.10.17.06.25 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2015 17:06:27 -0700 (PDT) Message-ID: <1426032383.5707.1.camel@phoenix> Subject: [PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path From: Axel Lin To: Kishon Vijay Abraham I Cc: Julia Lawall , Sylwester Nawrocki , Kyungmin Park , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 11 Mar 2015 08:06:23 +0800 X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the second lock on non-regmap path. Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state->regmap rmw operations) Reported-by: Julia Lawall Signed-off-by: Axel Lin --- drivers/phy/phy-exynos-mipi-video.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c index 8d6d117..df7519a 100644 --- a/drivers/phy/phy-exynos-mipi-video.c +++ b/drivers/phy/phy-exynos-mipi-video.c @@ -75,7 +75,6 @@ static int __set_phy_state(struct exynos_mipi_video_phy *state, } else { addr = state->regs + EXYNOS_MIPI_PHY_CONTROL(id / 2); - spin_lock(&state->slock); val = readl(addr); if (on) val |= reset;