diff mbox

[1/1] ARM: dts: Add keep-power-in-suspend to WiFi SDIO node for Peach Boards

Message ID 1428411814-21098-1-git-send-email-javier.martinez@collabora.co.uk
State Accepted
Commit b270687977280a2e49c7e53db14bd1b22f842295
Headers show

Commit Message

Javier Martinez Canillas April 7, 2015, 1:03 p.m. UTC
The Marvell mwifiex driver prevents the system to enter into a suspend
state if the card power is not preserved during a suspend/resume cycle.

So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
and Exynos5420 Peach Pit Chromebooks.

Add the keep-power-in-suspend Power Management property to the SDIO/MMC
node so the mwifiex suspend handler doesn't fail and the system is able
to enter into a suspend state.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
 arch/arm/boot/dts/exynos5800-peach-pi.dts  | 1 +
 2 files changed, 2 insertions(+)

Comments

Doug Anderson April 7, 2015, 3:09 p.m. UTC | #1
Javier,

On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> The Marvell mwifiex driver prevents the system to enter into a suspend
> state if the card power is not preserved during a suspend/resume cycle.
>
> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
> and Exynos5420 Peach Pit Chromebooks.
>
> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
> node so the mwifiex suspend handler doesn't fail and the system is able
> to enter into a suspend state.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>  arch/arm/boot/dts/exynos5800-peach-pi.dts  | 1 +
>  2 files changed, 2 insertions(+)

Reviewed-by: Doug Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Javier Martinez Canillas April 15, 2015, 8:07 a.m. UTC | #2
Hello Kukjin,

On 04/07/2015 05:09 PM, Doug Anderson wrote:
> Javier,
> 
> On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> The Marvell mwifiex driver prevents the system to enter into a suspend
>> state if the card power is not preserved during a suspend/resume cycle.
>>
>> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
>> and Exynos5420 Peach Pit Chromebooks.
>>
>> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
>> node so the mwifiex suspend handler doesn't fail and the system is able
>> to enter into a suspend state.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>>  arch/arm/boot/dts/exynos5800-peach-pi.dts  | 1 +
>>  2 files changed, 2 insertions(+)
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> 

Any comments on this patch?

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Javier Martinez Canillas April 30, 2015, 12:41 a.m. UTC | #3
Hello Kukjin,

On 04/15/2015 10:07 AM, Javier Martinez Canillas wrote:
> 
> On 04/07/2015 05:09 PM, Doug Anderson wrote:
>> Javier,
>> 
>> On Tue, Apr 7, 2015 at 6:03 AM, Javier Martinez Canillas
>> <javier.martinez@collabora.co.uk> wrote:
>>> The Marvell mwifiex driver prevents the system to enter into a suspend
>>> state if the card power is not preserved during a suspend/resume cycle.
>>>
>>> So Suspend-to-RAM and Suspend-to-idle is failing on Exynos5800 Peach Pi
>>> and Exynos5420 Peach Pit Chromebooks.
>>>
>>> Add the keep-power-in-suspend Power Management property to the SDIO/MMC
>>> node so the mwifiex suspend handler doesn't fail and the system is able
>>> to enter into a suspend state.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>> ---
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
>>>  arch/arm/boot/dts/exynos5800-peach-pi.dts  | 1 +
>>>  2 files changed, 2 insertions(+)
>> 
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> 
> 
> Any comments on this patch?
> 
> Best regards,
> Javier
> 

Gentle reminder about this patch.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 0788d08fb43e..146e71118a72 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -711,6 +711,7 @@ 
 	num-slots = <1>;
 	broken-cd;
 	cap-sdio-irq;
+	keep-power-in-suspend;
 	card-detect-delay = <200>;
 	clock-frequency = <400000000>;
 	samsung,dw-mshc-ciu-div = <1>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 412f41d62686..02eb8b15374f 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -674,6 +674,7 @@ 
 	num-slots = <1>;
 	broken-cd;
 	cap-sdio-irq;
+	keep-power-in-suspend;
 	card-detect-delay = <200>;
 	clock-frequency = <400000000>;
 	samsung,dw-mshc-ciu-div = <1>;