diff mbox

[PATCHv5,5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

Message ID 1431499020-3912-6-git-send-email-linux.amoon@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Anand Moon May 13, 2015, 6:37 a.m. UTC 
Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski May 13, 2015, 7:40 a.m. UTC | #1 
2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.

I am a little confused because you named this file as
exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
1. It references some specific phandles like &fan0 (cooling-device =
<&fan0 2 3>).
2. You include it only here.

So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
What is your intention?

Lukasz, you acked the patchset, is it fine?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Anand Moon May 13, 2015, 8:39 a.m. UTC | #2 
On 13 May 2015 at 13:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
>
> I am a little confused because you named this file as
> exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
> 1. It references some specific phandles like &fan0 (cooling-device =
> <&fan0 2 3>).
> 2. You include it only here.
>
> So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
> What is your intention?
>
> Lukasz, you acked the patchset, is it fine?
>
> Best regards,
> Krzysztof

Hi Krysxtof,

This file almost similar to below patch

https://patchwork.kernel.org/patch/5693321/

I had to create this new file as I was not able to register
#thermal-sensors to tmu_cpu0.

+       thermal-zones {
+               cpu0_thermal: cpu0-thermal {
+                       thermal-sensors = <&tmu_cpu0 0>;
+                       polling-delay-passive = <0>;
+                       polling-delay = <0>;

Earlier the DTS sensor's were not getting registers to the tmu_cpu0 sensors.

I am not aware If this file will be common to Exynos5 series.
I could not include any common dts file as I would through me
compilation error hence .dtsi  extension,

-Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski May 13, 2015, 10:05 a.m. UTC | #3 
2015-05-13 17:39 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 13:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
>>
>> I am a little confused because you named this file as
>> exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
>> 1. It references some specific phandles like &fan0 (cooling-device =
>> <&fan0 2 3>).
>> 2. You include it only here.
>>
>> So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
>> What is your intention?
>>
>> Lukasz, you acked the patchset, is it fine?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krysxtof,
>
> This file almost similar to below patch
>
> https://patchwork.kernel.org/patch/5693321/

It is similar but it has major difference: it references external (to
the file) phandle: fan0.

> I had to create this new file as I was not able to register
> #thermal-sensors to tmu_cpu0.
>
> +       thermal-zones {
> +               cpu0_thermal: cpu0-thermal {
> +                       thermal-sensors = <&tmu_cpu0 0>;
> +                       polling-delay-passive = <0>;
> +                       polling-delay = <0>;
>
> Earlier the DTS sensor's were not getting registers to the tmu_cpu0 sensors.
>
> I am not aware If this file will be common to Exynos5 series.
> I could not include any common dts file as I would through me
> compilation error hence .dtsi  extension,

So this looks exynos5420-odroidxu3 specific.

?ukasz, does this design looks good to you? You acked this but:
1. I cannot find your ack for patch 3/5.
2. I have doubts. :)

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index cd78816..9256fb5 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -13,6 +13,7 @@ 
 /dts-v1/;
 #include <dt-bindings/gpio/gpio.h>
 #include "exynos5800.dtsi"
+#include "exynos5-cpu-thermal.dtsi"
 
 / {
 	model = "Hardkernel Odroid XU3";