diff mbox

pwm: samsung: Use MODULE_DEVICE_TABLE() to include OF modalias

Message ID 1431563551-9461-1-git-send-email-javier.martinez@collabora.co.uk
State Accepted
Commit cccb94543c8299e0bc7564cc6f8b26e0f15bafde
Headers show

Commit Message

Javier Martinez Canillas May 14, 2015, 12:32 a.m. UTC
If the pwm-samsung driver is built as a module, modalias information is
not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
macro to export the OF device ID so the module contains that information.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 drivers/pwm/pwm-samsung.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski May 14, 2015, 12:37 a.m. UTC | #1
On 14.05.2015 09:32, Javier Martinez Canillas wrote:
> If the pwm-samsung driver is built as a module, modalias information is
> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
> macro to export the OF device ID so the module contains that information.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

I think many other Maxim/S[25]M drivers for Samsung boards may also be
affected... Probably they should also be updated.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Javier Martinez Canillas May 14, 2015, 12:47 a.m. UTC | #2
Hello Krzysztof,

On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote:
> On 14.05.2015 09:32, Javier Martinez Canillas wrote:
>> If the pwm-samsung driver is built as a module, modalias information is
>> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
>> macro to export the OF device ID so the module contains that information.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> I think many other Maxim/S[25]M drivers for Samsung boards may also be
> affected... Probably they should also be updated.
>

Yeah, I detected these since I'm preparing a series to reduce the delta
between exynos_defconfig and multi_v7_defconfig. And found these issues
since current multi_v7 policy is to build as much as possible as a module.
 
I think is unfortunate how many drivers are not providing proper module
aliases information and so building them as a module is less useful since
user-space can't associate the module with the modalias uevents to autoload.

Anyway, I'll take a look for other drivers and see if I can post similar
patches but now at least all the peripherals in the Exynos5 Chromebooks
are working when their drivers are built as a module.

> Best regards,
> Krzysztof
> 

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Javier Martinez Canillas May 21, 2015, 8:13 a.m. UTC | #3
Hello Thierry,

On 05/14/2015 02:37 AM, Krzysztof Kozlowski wrote:
> On 14.05.2015 09:32, Javier Martinez Canillas wrote:
>> If the pwm-samsung driver is built as a module, modalias information is
>> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
>> macro to export the OF device ID so the module contains that information.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> 

Any comments on this patch?

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thierry Reding May 21, 2015, 8:20 a.m. UTC | #4
On Thu, May 14, 2015 at 02:32:31AM +0200, Javier Martinez Canillas wrote:
> If the pwm-samsung driver is built as a module, modalias information is
> not filled so the module is not autoloaded. Use the MODULE_DEVICE_TABLE()
> macro to export the OF device ID so the module contains that information.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  drivers/pwm/pwm-samsung.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

Thierry
diff mbox

Patch

diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index ff201e1b9219..ada2d326dc3e 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -456,6 +456,7 @@  static const struct of_device_id samsung_pwm_matches[] = {
 	{ .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
 	{},
 };
+MODULE_DEVICE_TABLE(of, samsung_pwm_matches);
 
 static int pwm_samsung_parse_dt(struct samsung_pwm_chip *chip)
 {