Message ID | 1433758542-9843-4-git-send-email-a.hajda@samsung.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers | show |
Hi Andrzej, 2015-06-08 Andrzej Hajda <a.hajda@samsung.com>: > SoC checking code is not necessary anymore, as exynos_drm_match_add and > exynos_drm_platform_probe already properly handles situation when there are > no Exynos DRM components. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 27 +-------------------------- > 1 file changed, 1 insertion(+), 26 deletions(-) This series looks goods to me and works fine on my snow machine: Tested-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrzej, On Tue, 09 Jun 2015 16:46:52 -0300 Gustavo Padovan <gustavo@padovan.org> wrote: > Hi Andrzej, > > 2015-06-08 Andrzej Hajda <a.hajda@samsung.com>: > > > SoC checking code is not necessary anymore, as exynos_drm_match_add > > and exynos_drm_platform_probe already properly handles situation > > when there are no Exynos DRM components. > > > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > > --- > > drivers/gpu/drm/exynos/exynos_drm_drv.c | 27 > > +-------------------------- 1 file changed, 1 insertion(+), 26 > > deletions(-) > > This series looks goods to me and works fine on my snow machine: > > Tested-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > Gustavo It looks good to me. Reviewed-by: Hyungwon Hwang <human.hwang@samsung.com> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index cfbfb6c..9ec4027 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -560,34 +560,9 @@ static inline void exynos_drm_unregister_non_kms_drivers(void) ARRAY_SIZE(exynos_drm_non_kms_drivers)); } -static const char * const strings[] = { - "samsung,exynos3", - "samsung,exynos4", - "samsung,exynos5", - "samsung,exynos7", -}; - static int exynos_drm_init(void) { - bool is_exynos = false; - int ret, i; - - /* - * Register device object only in case of Exynos SoC. - * - * Below codes resolves temporarily infinite loop issue incurred - * by Exynos drm driver when using multi-platform kernel. - * So these codes will be replaced with more generic way later. - */ - for (i = 0; i < ARRAY_SIZE(strings); i++) { - if (of_machine_is_compatible(strings[i])) { - is_exynos = true; - break; - } - } - - if (!is_exynos) - return -ENODEV; + int ret; ret = exynos_drm_register_devices(); if (ret)
SoC checking code is not necessary anymore, as exynos_drm_match_add and exynos_drm_platform_probe already properly handles situation when there are no Exynos DRM components. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 27 +-------------------------- 1 file changed, 1 insertion(+), 26 deletions(-)