From patchwork Thu Jul 16 15:23:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 6808081 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4C9359F380 for ; Thu, 16 Jul 2015 15:24:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7775D205E6 for ; Thu, 16 Jul 2015 15:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76FF720661 for ; Thu, 16 Jul 2015 15:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754545AbbGPPYP (ORCPT ); Thu, 16 Jul 2015 11:24:15 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:33116 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbbGPPYO (ORCPT ); Thu, 16 Jul 2015 11:24:14 -0400 Received: by qged69 with SMTP id d69so4721751qge.0 for ; Thu, 16 Jul 2015 08:24:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1jTGJMx1K0/7UyJJlkhg00FwV5juHi8zzeTPgmFJI2o=; b=TiWs8nWUXdsV3Rq/PSyt9McAIa8dzdf0/G1WC2w0+fDa2h2MIe1JgZlSBQU+6BB/WE y0g93cc37ZXkc8H6pJ75DGY1uqP182JKrwKIu4Ldl7/ylNKNbFpJ4lYJi6+I67uvQrtP J67A6gtici7jjQp50AgOqM1XVmuZDZCvVjorTxgoP+tg3schuja4xnufOvvXhM6I5+7g aH27raZ5rP526TrFbUYFD+va/Ds7YsSZglbPEoNR8J1WULkXOlHxmOOIbrtxsHW6vV6H USN2eRBbWy5iAEEULtkNi+tljQJyI/vea97vuDuMj/l3Wmc0y0kHmS3JzUCr76XwpjWp jnEw== X-Received: by 10.140.41.134 with SMTP id z6mr17717423qgz.40.1437060254050; Thu, 16 Jul 2015 08:24:14 -0700 (PDT) Received: from jade.localdomain ([187.34.47.131]) by smtp.gmail.com with ESMTPSA id 124sm4164055qhx.34.2015.07.16.08.24.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 08:24:13 -0700 (PDT) From: Gustavo Padovan To: linux-samsung-soc@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com, jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de, Gustavo Padovan Subject: [PATCH v3 9/9] drm/exynos: return return value of exynos_crtc->enable_vblank Date: Thu, 16 Jul 2015 12:23:39 -0300 Message-Id: <1437060219-32278-9-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1437060219-32278-1-git-send-email-gustavo@padovan.org> References: <1437060219-32278-1-git-send-email-gustavo@padovan.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan Instead of blindly ignore the return value of enable_vblank return it to the upper DRM layer for error handling. Suggested-by: Joonyoung Shim Signed-off-by: Gustavo Padovan Reviewed-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index e9c291f..9bc2353 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -175,7 +175,7 @@ int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int pipe) return -EPERM; if (exynos_crtc->ops->enable_vblank) - exynos_crtc->ops->enable_vblank(exynos_crtc); + return exynos_crtc->ops->enable_vblank(exynos_crtc); return 0; }