From patchwork Fri Jul 17 20:27:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Laurent Navet [Mali]" X-Patchwork-Id: 6819041 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 051F19F380 for ; Fri, 17 Jul 2015 20:19:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2BFA7207E7 for ; Fri, 17 Jul 2015 20:19:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8914B207E3 for ; Fri, 17 Jul 2015 20:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753456AbbGQUTm (ORCPT ); Fri, 17 Jul 2015 16:19:42 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38038 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbbGQUTl (ORCPT ); Fri, 17 Jul 2015 16:19:41 -0400 Received: by wicmv11 with SMTP id mv11so51333342wic.1; Fri, 17 Jul 2015 13:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=rP0yCMZkOX0pe1C6JsbH22nhDRPrPxSq+bUdYp/PEhE=; b=WxFVzisWqKuKXQU4Wnkb4htg3XN/MtTSUCcd2DPKmHNtwOEH9PIJHIETgd6WXc4z1N jWJDkqU1h9KyDefVkH/VAnO5X4J1CXc7IGVh+jVOhWk4TYoWG/xA7dVbcLhWBSPFZ9HI WR84njdPLBb4RxxNUwLNJTRrqvDEcIo79KOPFomDPNNjExusJIoavWWmkExO48voKcGO hhxYJGYDGoAaqfVWxCuvo47h6EMWbQgxo+p0e/a95Vf8ksk0MliA/I6wf15jvgFtUMX7 Qrw7XaMaaL2sp0sPa6nm6n60M2U011Y5zHdbiqQf9mHV7sGvQffmSdxGHLSm8TatzcjY WNmw== X-Received: by 10.180.210.177 with SMTP id mv17mr317613wic.90.1437164379865; Fri, 17 Jul 2015 13:19:39 -0700 (PDT) Received: from paddy.home (ANantes-659-1-219-248.w2-1.abo.wanadoo.fr. [2.1.106.248]) by smtp.gmail.com with ESMTPSA id gt10sm9880673wib.20.2015.07.17.13.19.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Jul 2015 13:19:39 -0700 (PDT) From: Laurent Navet To: kgene@kernel.org, k.kozlowski@samsung.com, wsa@the-dreams.de Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Navet Subject: [PATCH V2] i2c: s3c2410: remove unused variable Date: Fri, 17 Jul 2015 22:27:19 +0200 Message-Id: <1437164839-9287-1-git-send-email-laurent.navet@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP in i2c_s3c_irq_nextbyte() ret is assigned zero and just used to return. Remove it and make i2c_s3c_irq_nextbyte() a void function. Found by using coccinelle. Signed-off-by: Laurent Navet --- drivers/i2c/busses/i2c-s3c2410.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 50bfd8c..612303a 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -146,7 +146,7 @@ static const struct platform_device_id s3c24xx_driver_ids[] = { }; MODULE_DEVICE_TABLE(platform, s3c24xx_driver_ids); -static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat); +static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat); #ifdef CONFIG_OF static const struct of_device_id s3c24xx_i2c_match[] = { @@ -405,11 +405,10 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c) * process an interrupt and work out what to do */ -static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) +static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) { unsigned long tmp; unsigned char byte; - int ret = 0; switch (i2c->state) { @@ -565,7 +564,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) tmp &= ~S3C2410_IICCON_IRQPEND; writel(tmp, i2c->regs + S3C2410_IICCON); out: - return ret; + return; } /* s3c24xx_i2c_irq