| Message ID | 1439496399-25791-1-git-send-email-gustavo@padovan.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, What about this patch? We need it to avoid the WARN_ON added by patch 2/2 that was already picked up by Daniel. Gustavo 2015-08-13 Gustavo Padovan <gustavo@padovan.org>: > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > These legacy helpers should only be used by shadow-attaching drivers. > KMS drivers has its own way to handle suspend/resume and don't need to > use these two helpers. > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c > index f1d6966..9bcf679 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > @@ -280,8 +280,6 @@ static struct drm_driver exynos_drm_driver = { > .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME, > .load = exynos_drm_load, > .unload = exynos_drm_unload, > - .suspend = exynos_drm_suspend, > - .resume = exynos_drm_resume, > .open = exynos_drm_open, > .preclose = exynos_drm_preclose, > .lastclose = exynos_drm_lastclose, > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 26, 2015 at 12:50:44PM -0300, Gustavo Padovan wrote: > Hi, > > What about this patch? We need it to avoid the WARN_ON added by patch > 2/2 that was already picked up by Daniel. That patch is only for 4.4, so not too time critical to get the exynos one in. But might be good to get it into 4.3. -Daniel > > Gustavo > > 2015-08-13 Gustavo Padovan <gustavo@padovan.org>: > > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > > > These legacy helpers should only be used by shadow-attaching drivers. > > KMS drivers has its own way to handle suspend/resume and don't need to > > use these two helpers. > > > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > --- > > drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c > > index f1d6966..9bcf679 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > > @@ -280,8 +280,6 @@ static struct drm_driver exynos_drm_driver = { > > .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME, > > .load = exynos_drm_load, > > .unload = exynos_drm_unload, > > - .suspend = exynos_drm_suspend, > > - .resume = exynos_drm_resume, > > .open = exynos_drm_open, > > .preclose = exynos_drm_preclose, > > .lastclose = exynos_drm_lastclose, > > -- > > 2.1.0 > >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index f1d6966..9bcf679 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -280,8 +280,6 @@ static struct drm_driver exynos_drm_driver = { .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME, .load = exynos_drm_load, .unload = exynos_drm_unload, - .suspend = exynos_drm_suspend, - .resume = exynos_drm_resume, .open = exynos_drm_open, .preclose = exynos_drm_preclose, .lastclose = exynos_drm_lastclose,