From patchwork Tue Aug 18 07:01:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 7028601 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EA0ECC05AC for ; Tue, 18 Aug 2015 07:02:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1E2AB2073F for ; Tue, 18 Aug 2015 07:02:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25EE420729 for ; Tue, 18 Aug 2015 07:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752500AbbHRHCP (ORCPT ); Tue, 18 Aug 2015 03:02:15 -0400 Received: from lists.s-osg.org ([54.187.51.154]:58205 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbbHRHCM (ORCPT ); Tue, 18 Aug 2015 03:02:12 -0400 Received: from minerva.sisa.samsung.com (95.111.23.95.dynamic.jazztel.es [95.23.111.95]) by lists.s-osg.org (Postfix) with ESMTPSA id 4A2CA462CB; Tue, 18 Aug 2015 00:02:09 -0700 (PDT) From: Javier Martinez Canillas To: Kukjin Kim Cc: Krzysztof Kozlowski , Geert Uytterhoeven , Doug Anderson , Olof Johansson , Gwendal Grignou , Sjoerd Simons , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver Date: Tue, 18 Aug 2015 09:01:21 +0200 Message-Id: <1439881281-22054-1-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.4.3 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config symbol because the driver uses some communication helper functions in drivers/platform/chrome/cros_ec_proto.c but other drivers depends on CROS_EC_PROTO instead. Mixing select and depends can lead to circular Kconfig dependencies so the MFD_CROS_EC select should be changed to a depends on CROS_EC_PROTO instead. But doing so will break git bisect-ability since MFD_CROS_EC will not be enabled anymore unless the default configs first explicitly enable the CROS_EC_PROTO dependency. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- arch/arm/configs/exynos_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 1ff2bfa2e183..537391ea37ac 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -177,6 +177,7 @@ CONFIG_DMADEVICES=y CONFIG_PL330_DMA=y CONFIG_CHROME_PLATFORMS=y CONFIG_CROS_EC_CHARDEV=y +CONFIG_CROS_EC_PROTO=y CONFIG_COMMON_CLK_MAX77686=y CONFIG_COMMON_CLK_MAX77802=y CONFIG_COMMON_CLK_S2MPS11=y