From patchwork Fri Oct 30 07:51:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 7525021 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A5F5FBEEA4 for ; Fri, 30 Oct 2015 07:51:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE90F207D9 for ; Fri, 30 Oct 2015 07:51:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95F8D207C1 for ; Fri, 30 Oct 2015 07:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758821AbbJ3Hvc (ORCPT ); Fri, 30 Oct 2015 03:51:32 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:44199 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758651AbbJ3Hvb (ORCPT ); Fri, 30 Oct 2015 03:51:31 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NX0004G9WHT7W10@mailout2.w1.samsung.com>; Fri, 30 Oct 2015 07:51:29 +0000 (GMT) X-AuditID: cbfec7f4-f79c56d0000012ee-72-56332180a7a6 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 18.07.04846.08123365; Fri, 30 Oct 2015 07:51:28 +0000 (GMT) Received: from localhost.localdomain ([10.252.80.64]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NX0004J1WHMG060@eusync3.samsung.com>; Fri, 30 Oct 2015 07:51:28 +0000 (GMT) From: Krzysztof Kozlowski To: Sangbeom Kim , Krzysztof Kozlowski , Lee Jones , Chanwoo Choi , Javier Martinez Canillas , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children Date: Fri, 30 Oct 2015 16:51:21 +0900 Message-id: <1446191481-21214-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBJMWRmVeSWpSXmKPExsVy+t/xq7oNisZhBjeWWltc//Kc1eLN2zVM Fq9fGFrc/3qU0eLyrjlsFjPO72OyuLjiC5MDu8eda3vYPLb032X36NuyitHj8ya5AJYoLpuU 1JzMstQifbsEroyvu70K7nFXbL52hbGB8SRnFyMnh4SAicSHxwtYIWwxiQv31rN1MXJxCAks ZZSY8G4+M4Tzn1Fi1ZXjYFVsAsYSm5cvAasSEZjJJLHw+HQgh4NDWCBEYtYOGRCTRUBV4uVh DpByXgF3iRkXX7JBLJCTOHlsMusERq4FjAyrGEVTS5MLipPScw31ihNzi0vz0vWS83M3MUL8 /2UH4+JjVocYBTgYlXh4fyQYhQmxJpYVV+YeYpTgYFYS4X0oaxwmxJuSWFmVWpQfX1Sak1p8 iFGag0VJnHfurvchQgLpiSWp2ampBalFMFkmDk6pBsYVccoN+n92ZvUbXv7btUK3X33CjCDN 0tAZwRfDHJ+4Gm5adcpMtlSK+ZkLOz/frplLjU2endey1Hx0rCP5yvO+Se5FGcpnzkzi5tCq Fo18cGVO/4MUG/NP3g8uZ57aaLvt5elIXdMFX3dmsKWuTnOao/nkU4HKzHvs9/90ZEj8afry zP+F3yUlluKMREMt5qLiRABAtXwS+wEAAA== Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02 device") added new MFD child devices for S2MPU02: RTC and clock provider (the clock provider with new compatible). However support for these devices was not added to existing drivers (rtc-s5m, clk-s2mps11). New drivers were not submitted neither. This means that the name of children devices is completely unused. The "samsung,s2mpu02-clk" compatible remains undocumented so it is unclear what is provided by that compatible. Clean up this by removing unused child devices and undocumented compatible. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Chanwoo Choi --- I don't think that removing the "samsung,s2mpu02-clk" compatible would be considered as ABI break because: 1. Kernel did not document it as ABI. 2. Kernel did not provide any kind of feature for that compatible. It was totally ignored. --- drivers/mfd/sec-core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index 2626fc0b5b8c..989076d6cb83 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = { }; static const struct mfd_cell s2mpu02_devs[] = { - { .name = "s2mpu02-pmic", }, - { .name = "s2mpu02-rtc", }, { - .name = "s2mpu02-clk", - .of_compatible = "samsung,s2mpu02-clk", - } + .name = "s2mpu02-pmic", + }, }; #ifdef CONFIG_OF