| Message ID | 1446202913-20467-1-git-send-email-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, 30 Oct 2015, Alim Akhtar wrote: > Currently S2MPSXX multifunction device is named as *-pmic, > and this MFD also supports regulator as a one of its MFD cell which > has the same name, which is a bit confusing. > > We did discussed different approaches about how the MFD and it > cells need to be named here [1]. > Based in the discussion this patch rename MFD regulator name as > *-regulator instead of current *-pmic. > > [1]-> https://lkml.org/lkml/2015/10/28/417 > > Suggested-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > drivers/mfd/sec-core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) You need to squash these patches together, or you will hurt bisectability for your platform. But the code looks good: Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 7c4e7be17f1e..c9802ba9be72 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -68,7 +68,7 @@ static const struct mfd_cell s5m8767_devs[] = { > > static const struct mfd_cell s2mps11_devs[] = { > { > - .name = "s2mps11-pmic", > + .name = "s2mps11-regulator", > }, { > .name = "s2mps14-rtc", > }, { > @@ -78,7 +78,7 @@ static const struct mfd_cell s2mps11_devs[] = { > }; > > static const struct mfd_cell s2mps13_devs[] = { > - { .name = "s2mps13-pmic", }, > + { .name = "s2mps13-regulator", }, > { .name = "s2mps13-rtc", }, > { > .name = "s2mps13-clk", > @@ -88,7 +88,7 @@ static const struct mfd_cell s2mps13_devs[] = { > > static const struct mfd_cell s2mps14_devs[] = { > { > - .name = "s2mps14-pmic", > + .name = "s2mps14-regulator", > }, { > .name = "s2mps14-rtc", > }, { > @@ -116,7 +116,7 @@ static const struct mfd_cell s2mpa01_devs[] = { > > static const struct mfd_cell s2mpu02_devs[] = { > { > - .name = "s2mpu02-pmic", > + .name = "s2mpu02-regulator", > }, > }; >
2015-10-30 20:01 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>: > Currently S2MPSXX multifunction device is named as *-pmic, > and this MFD also supports regulator as a one of its MFD cell which > has the same name, which is a bit confusing. > > We did discussed different approaches about how the MFD and it > cells need to be named here [1]. > Based in the discussion this patch rename MFD regulator name as > *-regulator instead of current *-pmic. > > [1]-> https://lkml.org/lkml/2015/10/28/417 > > Suggested-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > drivers/mfd/sec-core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Two comments from my side: 1. Lee already pointed issue with bisectability. This is a requirement. 2. What is missing in commit is the reason. Answer to question: Why? The answer is in LKML discussion but it should be provided here - in commit: because current naming is confusing and we want to sort it out. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index 7c4e7be17f1e..c9802ba9be72 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -68,7 +68,7 @@ static const struct mfd_cell s5m8767_devs[] = { static const struct mfd_cell s2mps11_devs[] = { { - .name = "s2mps11-pmic", + .name = "s2mps11-regulator", }, { .name = "s2mps14-rtc", }, { @@ -78,7 +78,7 @@ static const struct mfd_cell s2mps11_devs[] = { }; static const struct mfd_cell s2mps13_devs[] = { - { .name = "s2mps13-pmic", }, + { .name = "s2mps13-regulator", }, { .name = "s2mps13-rtc", }, { .name = "s2mps13-clk", @@ -88,7 +88,7 @@ static const struct mfd_cell s2mps13_devs[] = { static const struct mfd_cell s2mps14_devs[] = { { - .name = "s2mps14-pmic", + .name = "s2mps14-regulator", }, { .name = "s2mps14-rtc", }, { @@ -116,7 +116,7 @@ static const struct mfd_cell s2mpa01_devs[] = { static const struct mfd_cell s2mpu02_devs[] = { { - .name = "s2mpu02-pmic", + .name = "s2mpu02-regulator", }, };
Currently S2MPSXX multifunction device is named as *-pmic, and this MFD also supports regulator as a one of its MFD cell which has the same name, which is a bit confusing. We did discussed different approaches about how the MFD and it cells need to be named here [1]. Based in the discussion this patch rename MFD regulator name as *-regulator instead of current *-pmic. [1]-> https://lkml.org/lkml/2015/10/28/417 Suggested-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- drivers/mfd/sec-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)