| Message ID | 1446202913-20467-2-git-send-email-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 30 Oct 2015, Alim Akhtar wrote: > S2MPSXX regulators are probed with the same name as their parent MFD > device, this is a bit confusing. > As we discussed the same here[1], this patch rename the current regulator > names from *-pmic to *-regulator. > > [1]-> https://lkml.org/lkml/2015/10/28/417 > > Suggested-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > drivers/regulator/s2mps11.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) You need to squash these patches together, or you will hurt bisectability for your platform. But the code looks good: Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c > index b2f3a28e720c..3242ffc0cb25 100644 > --- a/drivers/regulator/s2mps11.c > +++ b/drivers/regulator/s2mps11.c > @@ -1199,11 +1199,11 @@ out: > } > > static const struct platform_device_id s2mps11_pmic_id[] = { > - { "s2mps11-pmic", S2MPS11X}, > - { "s2mps13-pmic", S2MPS13X}, > - { "s2mps14-pmic", S2MPS14X}, > + { "s2mps11-regulator", S2MPS11X}, > + { "s2mps13-regulator", S2MPS13X}, > + { "s2mps14-regulator", S2MPS14X}, > { "s2mps15-regulator", S2MPS15X}, > - { "s2mpu02-pmic", S2MPU02}, > + { "s2mpu02-regulator", S2MPU02}, > { }, > }; > MODULE_DEVICE_TABLE(platform, s2mps11_pmic_id);
diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index b2f3a28e720c..3242ffc0cb25 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -1199,11 +1199,11 @@ out: } static const struct platform_device_id s2mps11_pmic_id[] = { - { "s2mps11-pmic", S2MPS11X}, - { "s2mps13-pmic", S2MPS13X}, - { "s2mps14-pmic", S2MPS14X}, + { "s2mps11-regulator", S2MPS11X}, + { "s2mps13-regulator", S2MPS13X}, + { "s2mps14-regulator", S2MPS14X}, { "s2mps15-regulator", S2MPS15X}, - { "s2mpu02-pmic", S2MPU02}, + { "s2mpu02-regulator", S2MPU02}, { }, }; MODULE_DEVICE_TABLE(platform, s2mps11_pmic_id);
S2MPSXX regulators are probed with the same name as their parent MFD device, this is a bit confusing. As we discussed the same here[1], this patch rename the current regulator names from *-pmic to *-regulator. [1]-> https://lkml.org/lkml/2015/10/28/417 Suggested-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- drivers/regulator/s2mps11.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)