| Message ID | 1448607451-13784-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Andrzej, On 11/27/2015 03:57 AM, Andrzej Hajda wrote: > Since atomic check is called also for disabled crtcs it should skip > mode checking as it can be uninitialized. The patch fixes it. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > Hi Javier, > > Could you check with this patch. > The patch fixes the issue I reported. The display mode is correctly set with and without a HDMI monitor plugged. So on an Exynos5800 Peach Pi: Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
Hello Inki, On 11/27/2015 10:00 AM, Javier Martinez Canillas wrote: > Hello Andrzej, > > On 11/27/2015 03:57 AM, Andrzej Hajda wrote: >> Since atomic check is called also for disabled crtcs it should skip >> mode checking as it can be uninitialized. The patch fixes it. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> >> --- >> Hi Javier, >> >> Could you check with this patch. >> > > The patch fixes the issue I reported. The display mode is correctly set > with and without a HDMI monitor plugged. So on an Exynos5800 Peach Pi: > > Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> > This patch was never picked but fixes and important bug introduced in the v4.4 merge window so it should be sent during the v4.4-rc cycle. Best regards,
Hi Javier, 2015-12-09 19:51 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>: > Hello Inki, > > On 11/27/2015 10:00 AM, Javier Martinez Canillas wrote: >> Hello Andrzej, >> >> On 11/27/2015 03:57 AM, Andrzej Hajda wrote: >>> Since atomic check is called also for disabled crtcs it should skip >>> mode checking as it can be uninitialized. The patch fixes it. >>> >>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >>> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> >>> --- >>> Hi Javier, >>> >>> Could you check with this patch. >>> >> >> The patch fixes the issue I reported. The display mode is correctly set >> with and without a HDMI monitor plugged. So on an Exynos5800 Peach Pi: >> >> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> >> > > This patch was never picked but fixes and important > bug introduced in the v4.4 merge window so it should > be sent during the v4.4-rc cycle. Don't worry about that. Thanks, Inki Dae > > Best regards, > -- > Javier Martinez Canillas > Open Source Group > Samsung Research America > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index b3ba27f..e693571 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -55,6 +55,9 @@ static int exynos_crtc_atomic_check(struct drm_crtc *crtc, { struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc); + if (!state->enable) + return 0; + if (exynos_crtc->ops->atomic_check) return exynos_crtc->ops->atomic_check(exynos_crtc, state);
Since atomic check is called also for disabled crtcs it should skip mode checking as it can be uninitialized. The patch fixes it. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- Hi Javier, Could you check with this patch. Regards Andrzej drivers/gpu/drm/exynos/exynos_drm_crtc.c | 3 +++ 1 file changed, 3 insertions(+)