| Message ID | 1450868368-5650-3-git-send-email-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Dec 23, 2015 at 11:59:25AM +0100, Marek Szyprowski wrote: > This patch ensures that existing bus match callbacks don't return > negative values (which might be interpreted as potential errors in the > future) in case of positive match. This actually can't return a negative number - only valid devid bits are 0 to 9 inclusive, and this isn't going to ever change. So the patch isn't strictly necessary, but is good from the point of view of ensuring consistency. Hence: > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> > --- > arch/arm/common/sa1111.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c > index 3d22494..fb0a0a4 100644 > --- a/arch/arm/common/sa1111.c > +++ b/arch/arm/common/sa1111.c > @@ -1290,7 +1290,7 @@ static int sa1111_match(struct device *_dev, struct device_driver *_drv) > struct sa1111_dev *dev = SA1111_DEV(_dev); > struct sa1111_driver *drv = SA1111_DRV(_drv); > > - return dev->devid & drv->devid; > + return !!(dev->devid & drv->devid); > } > > static int sa1111_bus_suspend(struct device *dev, pm_message_t state) > -- > 1.9.2 >
diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 3d22494..fb0a0a4 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -1290,7 +1290,7 @@ static int sa1111_match(struct device *_dev, struct device_driver *_drv) struct sa1111_dev *dev = SA1111_DEV(_dev); struct sa1111_driver *drv = SA1111_DRV(_drv); - return dev->devid & drv->devid; + return !!(dev->devid & drv->devid); } static int sa1111_bus_suspend(struct device *dev, pm_message_t state)
This patch ensures that existing bus match callbacks don't return negative values (which might be interpreted as potential errors in the future) in case of positive match. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/common/sa1111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)