| Message ID | 1453193552-4761-3-git-send-email-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19.01.2016 17:52, Andi Shyti wrote: > the driver already loops once, there is no reason to loop again /s/the/The/ > for a different purpose. Merge the second loop into the first. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > drivers/clk/clk-s2mps11.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c > index 22d4df2..cae92fc 100644 > --- a/drivers/clk/clk-s2mps11.c > +++ b/drivers/clk/clk-s2mps11.c > @@ -202,12 +202,6 @@ static int s2mps11_clk_probe(struct platform_device *pdev) > ret = -ENOMEM; > goto err_reg; > } > - } > - > - for (i = 0; i < S2MPS11_CLKS_NUM; i++) { > - /* Skip clocks not present on S2MPS14 */ > - if (i == S2MPS11_CLK_CP && hwid == S2MPS14X) You changed this line in patch 1/3 - meaningless. This is a indication that this patch should go before 1st. BR, Krzysztof > - continue; > clk_table[i] = s2mps11_clks[i].clk; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c index 22d4df2..cae92fc 100644 --- a/drivers/clk/clk-s2mps11.c +++ b/drivers/clk/clk-s2mps11.c @@ -202,12 +202,6 @@ static int s2mps11_clk_probe(struct platform_device *pdev) ret = -ENOMEM; goto err_reg; } - } - - for (i = 0; i < S2MPS11_CLKS_NUM; i++) { - /* Skip clocks not present on S2MPS14 */ - if (i == S2MPS11_CLK_CP && hwid == S2MPS14X) - continue; clk_table[i] = s2mps11_clks[i].clk; }
the driver already loops once, there is no reason to loop again for a different purpose. Merge the second loop into the first. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/clk/clk-s2mps11.c | 6 ------ 1 file changed, 6 deletions(-)