| Message ID | 1453407813-14646-8-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: > It is better to use dev_*() log functions instead of pr_*() to print > information about the device in the kernel log in a standardized way. > > This also allows to remove the local pr_fmt() defined macro. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 3e6d6bff5154..e1739d19ce9a 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -12,8 +12,6 @@ * */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - #include <linux/slab.h> #include <linux/rtc.h> #include <linux/delay.h> @@ -245,8 +243,9 @@ static int max77686_rtc_tm_to_data(struct rtc_time *tm, u8 *data, data[RTC_YEAR] = tm->tm_year > 100 ? (tm->tm_year - 100) : 0; if (tm->tm_year < 100) { - pr_warn("RTC can't handle year %d. Assume it's 2000.\n", - 1900 + tm->tm_year); + dev_warn(info->dev, + "RTC can't handle year %d. Assume it's 2000\n", + 1900 + tm->tm_year); return -EINVAL; } } else {
It is better to use dev_*() log functions instead of pr_*() to print information about the device in the kernel log in a standardized way. This also allows to remove the local pr_fmt() defined macro. Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes in v2: None drivers/rtc/rtc-max77686.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)