From patchwork Thu Mar 3 08:44:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 8490221 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 87A9A9F8A8 for ; Thu, 3 Mar 2016 08:44:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8D331201EC for ; Thu, 3 Mar 2016 08:44:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 052822022A for ; Thu, 3 Mar 2016 08:44:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756153AbcCCIoy (ORCPT ); Thu, 3 Mar 2016 03:44:54 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:38488 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbcCCIox (ORCPT ); Thu, 3 Mar 2016 03:44:53 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O3G00B0LGAQ8W00@mailout4.w1.samsung.com>; Thu, 03 Mar 2016 08:44:50 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-79-56d7f982a482 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 4C.B9.21385.289F7D65; Thu, 3 Mar 2016 08:44:50 +0000 (GMT) Received: from localhost.localdomain ([10.113.63.52]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O3G0068BGAGUN60@eusync1.samsung.com>; Thu, 03 Mar 2016 08:44:50 +0000 (GMT) From: Krzysztof Kozlowski To: Zhang Rui , Eduardo Valentin , Lukasz Majewski , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2] thermal: Fix build error of missing devm_ioremap_resource on UM Date: Thu, 03 Mar 2016 17:44:37 +0900 Message-id: <1456994677-3024-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 2.5.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKJMWRmVeSWpSXmKPExsVy+t/xy7pNP6+HGazbyGsx/8o1VovXLwwt 3jzczGhxedccNovPvUcYLWac38dk8eRhH5sDu8fOWXfZPRbvecnk0bdlFaPH501yASxRXDYp qTmZZalF+nYJXBmtLQIFT5UqHvQcZ2lgXCXTxcjJISFgIvHsw2oWCFtM4sK99WxdjFwcQgJL GSV+92xmgXD+M0psu7+YFaSKTcBYYvPyJWBVIgJXGCXanl8Ha2cWMJT4+e4PO4gtLBAqca/5 HxOIzSKgKtHyay0jiM0r4CZxYOJXoHoOoHVyEgsupE9g5F7AyLCKUTS1NLmgOCk910ivODG3 uDQvXS85P3cTIyQwvu5gXHrM6hCjAAejEg/vjYbrYUKsiWXFlbmHGCU4mJVEeJ2/A4V4UxIr q1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TBKdXA2Kimc9BT3H5Lu1RZ RY3qn2Dxg+//bLy74PQBBdUprk9WZf7amr7RfwF/0yGL+R9FJR++vcE2bdMV4wABWe4WdoU0 79vfGT+mJZV889LfcNF/g0VIwiWne7e2iXAvvyvwwkZi/tHr/mnr9C9mzZy3yshmnZBxYvP1 whfhRtOM7d0qW38lv1wfqcRSnJFoqMVcVJwIAJG2juUIAgAA Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The devres.o gets linked if HAS_IOMEM is present so on ARCH=um allyesconfig (COMPILE_TEST) failed on many files with: drivers/built-in.o: In function `kirkwood_thermal_probe': kirkwood_thermal.c:(.text+0x390a25): undefined reference to `devm_ioremap_resource' drivers/built-in.o: In function `exynos_tmu_probe': exynos_tmu.c:(.text+0x39246b): undefined reference to `devm_ioremap' The users of devm_ioremap_resource() which are compile-testable should depend on HAS_IOMEM. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Fix linking error also on TI. 2. Use different approach for HAS_IOMEM dependency. IT is needed only for COMPILE_TEST so use && to show that. --- drivers/thermal/Kconfig | 19 +++++++++---------- drivers/thermal/samsung/Kconfig | 1 + 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 5e7c97a3f1d8..bf0247869add 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -177,7 +177,7 @@ config THERMAL_EMULATION config HISI_THERMAL tristate "Hisilicon thermal driver" - depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST + depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST && HAS_IOMEM help Enable this to plug hisilicon's thermal sensor driver into the Linux thermal framework. cpufreq is used as the cooling device to throttle @@ -196,7 +196,7 @@ config IMX_THERMAL config SPEAR_THERMAL tristate "SPEAr thermal sensor driver" - depends on PLAT_SPEAR || COMPILE_TEST + depends on PLAT_SPEAR || COMPILE_TEST && HAS_IOMEM depends on OF help Enable this to plug the SPEAr thermal sensor driver into the Linux @@ -204,7 +204,7 @@ config SPEAR_THERMAL config ROCKCHIP_THERMAL tristate "Rockchip thermal driver" - depends on ARCH_ROCKCHIP || COMPILE_TEST + depends on ARCH_ROCKCHIP || COMPILE_TEST && HAS_IOMEM depends on RESET_CONTROLLER help Rockchip thermal driver provides support for Temperature sensor @@ -214,15 +214,14 @@ config ROCKCHIP_THERMAL config RCAR_THERMAL tristate "Renesas R-Car thermal driver" - depends on ARCH_SHMOBILE || COMPILE_TEST - depends on HAS_IOMEM + depends on ARCH_SHMOBILE || COMPILE_TEST && HAS_IOMEM help Enable this to plug the R-Car thermal sensor driver into the Linux thermal framework. config KIRKWOOD_THERMAL tristate "Temperature sensor on Marvell Kirkwood SoCs" - depends on MACH_KIRKWOOD || COMPILE_TEST + depends on MACH_KIRKWOOD || COMPILE_TEST && HAS_IOMEM depends on OF help Support for the Kirkwood thermal sensor driver into the Linux thermal @@ -230,7 +229,7 @@ config KIRKWOOD_THERMAL config DOVE_THERMAL tristate "Temperature sensor on Marvell Dove SoCs" - depends on ARCH_DOVE || MACH_DOVE || COMPILE_TEST + depends on ARCH_DOVE || MACH_DOVE || COMPILE_TEST && HAS_IOMEM depends on OF help Support for the Dove thermal sensor driver in the Linux thermal @@ -248,7 +247,7 @@ config DB8500_THERMAL config ARMADA_THERMAL tristate "Armada 370/XP thermal management" - depends on ARCH_MVEBU || COMPILE_TEST + depends on ARCH_MVEBU || COMPILE_TEST && HAS_IOMEM depends on OF help Enable this option if you want to have support for thermal management @@ -367,14 +366,14 @@ config INTEL_PCH_THERMAL config MTK_THERMAL tristate "Temperature sensor driver for mediatek SoCs" - depends on ARCH_MEDIATEK || COMPILE_TEST + depends on ARCH_MEDIATEK || COMPILE_TEST && HAS_IOMEM default y help Enable this option if you want to have support for thermal management controller present in Mediatek SoCs menu "Texas Instruments thermal drivers" -depends on ARCH_HAS_BANDGAP || COMPILE_TEST +depends on ARCH_HAS_BANDGAP || COMPILE_TEST && HAS_IOMEM source "drivers/thermal/ti-soc-thermal/Kconfig" endmenu diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig index e0da3865e060..222e644169f0 100644 --- a/drivers/thermal/samsung/Kconfig +++ b/drivers/thermal/samsung/Kconfig @@ -1,6 +1,7 @@ config EXYNOS_THERMAL tristate "Exynos thermal management unit driver" depends on THERMAL_OF + depends on HAS_IOMEM help If you say yes here you get support for the TMU (Thermal Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises