From patchwork Tue Apr 19 20:10:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 8883201 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3A98A9F36E for ; Tue, 19 Apr 2016 20:11:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4A929202F2 for ; Tue, 19 Apr 2016 20:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E2D0202C8 for ; Tue, 19 Apr 2016 20:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932071AbcDSULH (ORCPT ); Tue, 19 Apr 2016 16:11:07 -0400 Received: from lists.s-osg.org ([54.187.51.154]:42567 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107AbcDSULF (ORCPT ); Tue, 19 Apr 2016 16:11:05 -0400 Received: from localhost.localdomain.com (host-26.58.217.201.copaco.com.py [201.217.58.26]) by lists.s-osg.org (Postfix) with ESMTPSA id A84D2E27AB; Tue, 19 Apr 2016 20:11:04 +0000 (UTC) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Wolfram Sang , Kukjin Kim , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] i2c: s3c2410: Print errno code in error logs Date: Tue, 19 Apr 2016 16:10:40 -0400 Message-Id: <1461096641-19788-1-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver not always prints the error code in case of a failure but this information can be very useful for debugging. So let's print if available. Signed-off-by: Javier Martinez Canillas --- Hello, This patch and 2/2 were only build tested because I don't have access to a board using this IP block. I just noticed these issues when comparing the i2c-s3c2410 driver with i2c-exynos5 where I did some fixes recently. I think the patches are simple enough that is safe to pick them but of course testing will be highly appreciated. Best regards, Javier drivers/i2c/busses/i2c-s3c2410.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 362a6de54833..4b873fe9a75b 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -944,7 +944,7 @@ static int s3c24xx_i2c_cpufreq_transition(struct notifier_block *nb, i2c_unlock_adapter(&i2c->adap); if (ret < 0) - dev_err(i2c->dev, "cannot find frequency\n"); + dev_err(i2c->dev, "cannot find frequency (%d)\n", ret); else dev_info(i2c->dev, "setting freq %d\n", got); } @@ -995,7 +995,8 @@ static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c) ret = gpio_request(gpio, "i2c-bus"); if (ret) { - dev_err(i2c->dev, "gpio [%d] request failed\n", gpio); + dev_err(i2c->dev, "gpio [%d] request failed (%d)\n", + gpio, ret); goto free_gpio; } } @@ -1199,7 +1200,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) ret = s3c24xx_i2c_init(i2c); clk_disable(i2c->clk); if (ret != 0) { - dev_err(&pdev->dev, "I2C controller init failed\n"); + dev_err(&pdev->dev, "I2C controller init failed (%d)\n", ret); return ret; } /* find the IRQ for this unit (note, this relies on the init call to @@ -1209,7 +1210,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) if (!(i2c->quirks & QUIRK_POLL)) { i2c->irq = ret = platform_get_irq(pdev, 0); if (ret <= 0) { - dev_err(&pdev->dev, "cannot find IRQ\n"); + dev_err(&pdev->dev, "cannot find IRQ (%d)\n", ret); clk_unprepare(i2c->clk); return ret; } @@ -1218,7 +1219,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) dev_name(&pdev->dev), i2c); if (ret != 0) { - dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq); + dev_err(&pdev->dev, "cannot claim IRQ %d (%d)\n", + i2c->irq, ret); clk_unprepare(i2c->clk); return ret; } @@ -1226,7 +1228,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) ret = s3c24xx_i2c_register_cpufreq(i2c); if (ret < 0) { - dev_err(&pdev->dev, "failed to register cpufreq notifier\n"); + dev_err(&pdev->dev, "failed to register cpufreq notifier (%d)\n", + ret); clk_unprepare(i2c->clk); return ret; } @@ -1246,7 +1249,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) ret = i2c_add_numbered_adapter(&i2c->adap); if (ret < 0) { - dev_err(&pdev->dev, "failed to add bus to i2c core\n"); + dev_err(&pdev->dev, "failed to add bus to i2c core (%d)\n", + ret); pm_runtime_disable(&pdev->dev); s3c24xx_i2c_deregister_cpufreq(i2c); clk_unprepare(i2c->clk);