From patchwork Thu May 26 16:32:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 9137239 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 67B73607D3 for ; Thu, 26 May 2016 16:33:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CB7328195 for ; Thu, 26 May 2016 16:33:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 515EF282F7; Thu, 26 May 2016 16:33:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0DE6828195 for ; Thu, 26 May 2016 16:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753612AbcEZQcj (ORCPT ); Thu, 26 May 2016 12:32:39 -0400 Received: from lists.s-osg.org ([54.187.51.154]:49863 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbcEZQci (ORCPT ); Thu, 26 May 2016 12:32:38 -0400 Received: from minerva.localdomain (host-190.58.217.201.copaco.com.py [201.217.58.190]) by lists.s-osg.org (Postfix) with ESMTPSA id 6FF2FE28DA; Thu, 26 May 2016 09:33:08 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, Chanwoo Choi , Javier Martinez Canillas , Krzysztof Kozlowski , Lee Jones Subject: [RESEND RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall() Date: Thu, 26 May 2016 12:32:19 -0400 Message-Id: <1464280340-13228-2-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1464280340-13228-1-git-send-email-javier@osg.samsung.com> References: <1464280340-13228-1-git-send-email-javier@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver's init function is called at subsys init call level but the dependencies provided by the driver are looked up by drivers that have probe deferral support, so manual ordering of init calls isn't needed. Suggested-by: Krzysztof Kozlowski Signed-off-by: Javier Martinez Canillas --- Hello, I checked an the only users in mainline for this driver are the Exynos3250 Monk and Rinato boards. In both, only two regulators are used (safeout_reg and motor_reg) and these are looked up by the drivers phy-samsung-usb2 and regulator-haptic respectively, and both support probe deferral. Best regards, Javier drivers/mfd/max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index 2280b3fdcf68..6c245128ab2e 100644 --- a/drivers/mfd/max14577.c +++ b/drivers/mfd/max14577.c @@ -561,7 +561,7 @@ static int __init max14577_i2c_init(void) return i2c_add_driver(&max14577_i2c_driver); } -subsys_initcall(max14577_i2c_init); +module_init(max14577_i2c_init); static void __exit max14577_i2c_exit(void) {