From patchwork Tue Jun 28 11:21:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 9202951 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 78E5860757 for ; Tue, 28 Jun 2016 11:22:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B29D28604 for ; Tue, 28 Jun 2016 11:22:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5CD0A28621; Tue, 28 Jun 2016 11:22:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE9E32861C for ; Tue, 28 Jun 2016 11:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbcF1LV4 (ORCPT ); Tue, 28 Jun 2016 07:21:56 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:45504 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbcF1LVz (ORCPT ); Tue, 28 Jun 2016 07:21:55 -0400 Received: from epcpsbgm1new.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O9H00DXIBKHAA50@mailout4.samsung.com>; Tue, 28 Jun 2016 20:21:53 +0900 (KST) X-AuditID: cbfee61a-f79106d000000835-7a-57725dd15a1e Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id A1.58.02101.1DD52775; Tue, 28 Jun 2016 20:21:53 +0900 (KST) Received: from AMDC1976.DIGITAL.local ([106.120.53.102]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O9H00K2YBK59LA0@mmp2.samsung.com>; Tue, 28 Jun 2016 20:21:53 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Chanwoo Choi Cc: MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com Subject: [PATCH] PM / devfreq: exynos: fix error path in exynos_bus_probe() Date: Tue, 28 Jun 2016 13:21:09 +0200 Message-id: <1467112869-30488-2-git-send-email-b.zolnierkie@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1467112869-30488-1-git-send-email-b.zolnierkie@samsung.com> References: <1467112869-30488-1-git-send-email-b.zolnierkie@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPLMWRmVeSWpSXmKPExsVy+t9jQd2LsUXhBtt/i1psnLGe1eL6l+es Fq9fGFr0P37NbHG26Q27xabH11gtLu+aw2bxufcIo8WM8/uYLG43rmBz4PLYtKqTzWPzknqP vi2rGD0+b5ILYInisklJzcksSy3St0vgyljSf4yl4CxbxfQVlQ2MB1m7GDk5JARMJJ6f2ssG YYtJXLi3Hsjm4hASmMUoMbu3gR3C+cUo8a51PxNIFZuAlcTE9lWMILaIgIbEzL9XGEGKmAWO M0l8fNcENlZYwFviYGM3WAOLgKrEqlvzmUFsXgEPiQmHnkKtk5M4eWwyWD2ngKfE68fHwWqE gGrOrXnAPIGRdwEjwypGidSC5ILipPRcw7zUcr3ixNzi0rx0veT83E2M4GB7JrWD8eAu90OM AhyMSjy8O+oKw4VYE8uKK3MPMUpwMCuJ8P6OKQoX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzvv4 /7owIYH0xJLU7NTUgtQimCwTB6dUA+P5p4+UrjNn3XJiZAvclu6gsvpfbvymprzqn0vfZXMe V68/s11co/2vfJ15SszFCUx+L9nkI29YPH0gJWqbtmWzQezqM+m87foHDok9mSfwRvzi8Suc Yvf+75l90jLtivnR+7/XGu+QzxMqTNu86bgXy+aknpcran9KewdVtfc8D074+u7Ee38lluKM REMt5qLiRAC8EGf4MgIAAA== Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In case of exynos_bus_parse_of() failure the code shouldn't try to remove the OPP table and disable+unprepare bus->clk as it has been already handled in exynos_bus_parse_of(). Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Chanwoo Choi --- drivers/devfreq/exynos-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 2363d0a..e946f8f 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -407,7 +407,7 @@ static int exynos_bus_probe(struct platform_device *pdev) /* Parse the device-tree to get the resource information */ ret = exynos_bus_parse_of(np, bus); if (ret < 0) - goto err; + return ret; profile = devm_kzalloc(dev, sizeof(*profile), GFP_KERNEL); if (!profile) {