From patchwork Thu Jul 14 12:47:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 9229769 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E3FF06075D for ; Thu, 14 Jul 2016 12:48:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D54BB27FA9 for ; Thu, 14 Jul 2016 12:48:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C95D2281A7; Thu, 14 Jul 2016 12:48:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F0A727FA9 for ; Thu, 14 Jul 2016 12:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751113AbcGNMsI (ORCPT ); Thu, 14 Jul 2016 08:48:08 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:24063 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbcGNMsH (ORCPT ); Thu, 14 Jul 2016 08:48:07 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OAB00EH2283BG80@mailout2.w1.samsung.com>; Thu, 14 Jul 2016 13:48:03 +0100 (BST) X-AuditID: cbfec7f5-f792a6d000001302-af-57878a03977d Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 45.9D.04866.30A87875; Thu, 14 Jul 2016 13:48:03 +0100 (BST) Received: from AMDC2174.DIGITAL.local ([106.120.53.17]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OAB00JQE27VPB40@eusync2.samsung.com>; Thu, 14 Jul 2016 13:48:03 +0100 (BST) From: Krzysztof Kozlowski To: Jaehoon Chung , Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz Subject: [PATCH] ARM: dts: exynos: Properly select eMMC HighSpeed mode Date: Thu, 14 Jul 2016 14:47:38 +0200 Message-id: <1468500458-7142-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFJMWRmVeSWpSXmKPExsVy+t/xK7rMXe3hBvPO81lsnLGe1WL+kXOs Fjd+tbFavH5haNH/+DWzxabH11gtLu+aw2Yx4/w+JgcOj02rOtk8Ni+p9+jbsorR4/MmuQCW KC6blNSczLLUIn27BK6M+Qf+Mhb85a7Y92Y6cwNjK1cXIyeHhICJxNXeM+wQtpjEhXvr2boY uTiEBJYySlw7MZMNJCEk0Mgk8WyeKYjNJmAssXn5ErAiEZD47ZkXwIqYBSwktm5dDTZJWMBN 4mfvTBYQm0VAVeLK79VgNbxA8R9PljFBbJOTOHlsMusERu4FjAyrGEVTS5MLipPSc430ihNz i0vz0vWS83M3MUJC5OsOxqXHrA4xCnAwKvHwPshrCxdiTSwrrsw9xCjBwawkwlvc1h4uxJuS WFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2ampBalFMFkmDk6pBsb4ff+iQ8+Y5N3S V//LwzJ10gHrLdMe/7rje4lR4fayN7dmWX/iWv2nxvj2gyNd/nfjl77q0wj4t1XKQeR4okHo 3NVL94Vf2hNy5k7wfbWmNw/buzfZL/n/ikmlf06V1CYphhkKzQvX7pbS0omqSllw78F/nYnt 5YFumjvlW8Rrb6nmT1i9g1tYiaU4I9FQi7moOBEAPdo8AQ0CAAA= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Exynos5410 supports eMMC version 4.41 so HS200 is the top mode which should be configured. This is reflected in usage of "samsung,exynos5250-dw-mshc" compatible. However DTS contained also property "mmc-hs400-1_8v" which is parsed by MMC core therefore resulting in mixed configuration. MMC core set HS400 but dwmmc_exynos driver did not configure the data strobe for HS400 DDR mode. Removal of HS400 properties fixes semi-random mmc errors during boot: mmc_host mmc0: Bus speed (slot 0) = 400000000Hz (slot req 200000000Hz, actual 200000000HZ div = 1) mmc0: mmc_select_hs400 failed, error -84 mmc0: error -84 whilst initialising MMC card Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts index d9499310a301..7536164438ca 100644 --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts @@ -447,14 +447,12 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; - samsung,dw-mshc-hs400-timing = <0 2>; samsung,read-strobe-delay = <90>; pinctrl-names = "default"; pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd>; bus-width = <8>; cap-mmc-highspeed; mmc-hs200-1_8v; - mmc-hs400-1_8v; vmmc-supply = <&ldo20_reg>; vqmmc-supply = <&ldo11_reg>; };