From patchwork Mon Aug 15 10:17:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Perr Zhang X-Patchwork-Id: 9280769 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 87CAF607FD for ; Mon, 15 Aug 2016 10:17:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7741F28C5A for ; Mon, 15 Aug 2016 10:17:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BCD628C5D; Mon, 15 Aug 2016 10:17:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E782328C5A for ; Mon, 15 Aug 2016 10:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037AbcHOKRi (ORCPT ); Mon, 15 Aug 2016 06:17:38 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:21078 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbcHOKRh (ORCPT ); Mon, 15 Aug 2016 06:17:37 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=from:to:cc:subject:date:message-id; b=O/NFtzbOQfHqYzTRj0vagxxjNv1MAyUU00gVTCr/SbSUzvGF6Z1L/1B0qSgzvOyQ6vf8Y9dIvMcb U6a9+cVgMpFgRiRvIN2o9rqTEOQA9dgIq1NPO9H07CV9v7dqYh6e Received: from localhost.localdomain (123.168.236.180 [123.168.236.180]) by mx.zohomail.com with SMTPS id 14712562553131010.4427300368332; Mon, 15 Aug 2016 03:17:35 -0700 (PDT) From: perr To: tomasz.figa@gmail.com Cc: k.kozlowski@samsung.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, perr Subject: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler Date: Mon, 15 Aug 2016 18:17:07 +0800 Message-Id: <1471256227-6282-1-git-send-email-strongbox8@zoho.com> X-Mailer: git-send-email 1.9.3 X-ZohoMail: Z_632174891 SPT_1 SLF_E X-Zoho-Virus-Status: 2 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Because chained_irq_enter() has already called chip->irq_mask() and chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), so it's not necessary to call chip->irq_*() here. Signed-off-by: perr Acked-by: Tomasz Figa Reviewed-by: Krzysztof Kozlowski --- drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 051b5bf..d32fa2b 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) int eint_irq; chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); generic_handle_irq(eint_irq); - chip->irq_unmask(&desc->irq_data); + chained_irq_exit(chip, desc); }