| Message ID | 1472044039-16536-2-git-send-email-woogyom.kim@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, Aug 24, 2016 at 10:07:15PM +0900, Milo Kim wrote: > * GPIO for HDMI hot plug detect > GPX3_7 is used. The HPD awareness is done when the GPIO is active high and > single ended. > > * Enable HDMI block in Exynos5420 > HDMI VDD and PLL consume 1.0V LDO6 (PVDD_ANAIP_1V0) and HDMI oscillator > requires 1.8V LDO7 (PVDD_ANAIP_1V8). > > * Support HDMI display data channel > I2C #2 is assigned for the HDMI DDC. It enables the EDID access. > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim <woogyom.kim@gmail.com> > --- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts > index 39a3b81..2fb5708 100644 > --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts > +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts > @@ -70,6 +70,19 @@ > status = "disabled"; > }; > First of all - it looks like these DTS patches do not depend on DRM part, do they? > +&hdmi { > + hpd-gpios = <&gpx3 7 GPIO_OPEN_SOURCE>; Are you sure it is open-source type? > + vdd_osc-supply = <&ldo7_reg>; > + vdd_pll-supply = <&ldo6_reg>; > + vdd-supply = <&ldo6_reg>; > + ddc = <&i2c_2>; > + status = "okay"; > +}; > + > +&i2c_2 { > + status = "okay"; Hm, what is connected here? Please put it in alphabetical order (so after hsi2c_4). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, On 08/25/2016 04:05 AM, Krzysztof Kozlowski wrote: > First of all - it looks like these DTS patches do not depend on DRM > part, do they? I just sent the v4 patch for DTS. DRM patch-set was sent separately. Thanks for your advise. Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts index 39a3b81..2fb5708 100644 --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts @@ -70,6 +70,19 @@ status = "disabled"; }; +&hdmi { + hpd-gpios = <&gpx3 7 GPIO_OPEN_SOURCE>; + vdd_osc-supply = <&ldo7_reg>; + vdd_pll-supply = <&ldo6_reg>; + vdd-supply = <&ldo6_reg>; + ddc = <&i2c_2>; + status = "okay"; +}; + +&i2c_2 { + status = "okay"; +}; + &hsi2c_4 { status = "okay";
* GPIO for HDMI hot plug detect GPX3_7 is used. The HPD awareness is done when the GPIO is active high and single ended. * Enable HDMI block in Exynos5420 HDMI VDD and PLL consume 1.0V LDO6 (PVDD_ANAIP_1V0) and HDMI oscillator requires 1.8V LDO7 (PVDD_ANAIP_1V8). * Support HDMI display data channel I2C #2 is assigned for the HDMI DDC. It enables the EDID access. Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Milo Kim <woogyom.kim@gmail.com> --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)