| Message ID | 1472720817-20362-2-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Sep 01, 2016 at 11:06:50AM +0200, Javier Martinez Canillas wrote: > The skeleton.dtsi file was removed in ARM64 for different reasons as > explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi"). > > These also applies to ARM and it will also allow to get rid of the > following DTC warnings in the future: > > "Node /memory has a reg or ranges property, but no unit name" > > But these boards don't have a memory node defined, so removing the > skeleton.dtsi inclusion in exynos5440.dtsi will cause a change in > the compiled DTB. Add a dummy memory node so the compiled DTB does > not change if the skeleton.dtsi is removed from exynos5440.dtsi. > > Eventually the correct starting addresses and sizes should be used > but I didn't find that information. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Changes in v2: > - Add a fixme to specify that the correct memory values should be set. > (Bartlomiej Zolnierkiewicz) > - Fix commit message (Krzysztof Kozlowski). > > arch/arm/boot/dts/exynos5440-sd5v1.dts | 6 ++++++ > arch/arm/boot/dts/exynos5440-ssdk5440.dts | 6 ++++++ > 2 files changed, 12 insertions(+) > Thanks, applied. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts index a98501bab6fc..afd21a41e05b 100644 --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts @@ -20,6 +20,12 @@ bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200"; }; + /* FIXME: set reg property with correct start address and size */ + memory { + device_type = "memory"; + reg = <0 0>; + }; + fixed-rate-clocks { xtal { compatible = "samsung,clock-xtal"; diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts index 6a0d802e87c8..bdb3bf622e2f 100644 --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts @@ -21,6 +21,12 @@ bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200"; }; + /* FIXME: set reg property with correct start address and size */ + memory { + device_type = "memory"; + reg = <0 0>; + }; + fixed-rate-clocks { xtal { compatible = "samsung,clock-xtal";
The skeleton.dtsi file was removed in ARM64 for different reasons as explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi"). These also applies to ARM and it will also allow to get rid of the following DTC warnings in the future: "Node /memory has a reg or ranges property, but no unit name" But these boards don't have a memory node defined, so removing the skeleton.dtsi inclusion in exynos5440.dtsi will cause a change in the compiled DTB. Add a dummy memory node so the compiled DTB does not change if the skeleton.dtsi is removed from exynos5440.dtsi. Eventually the correct starting addresses and sizes should be used but I didn't find that information. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes in v2: - Add a fixme to specify that the correct memory values should be set. (Bartlomiej Zolnierkiewicz) - Fix commit message (Krzysztof Kozlowski). arch/arm/boot/dts/exynos5440-sd5v1.dts | 6 ++++++ arch/arm/boot/dts/exynos5440-ssdk5440.dts | 6 ++++++ 2 files changed, 12 insertions(+)