From patchwork Sun Oct 16 14:19:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michael_Niew=C3=B6hner?= X-Patchwork-Id: 9378133 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7652B607FD for ; Sun, 16 Oct 2016 14:20:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5AB3928BDF for ; Sun, 16 Oct 2016 14:20:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4E73A28BE8; Sun, 16 Oct 2016 14:20:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=2.0 tests=BASE64_LENGTH_79_INF, BAYES_00, MIME_BASE64_BLANKS,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C5ED28BDF for ; Sun, 16 Oct 2016 14:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756171AbcJPOUs (ORCPT ); Sun, 16 Oct 2016 10:20:48 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21380 "EHLO sender163-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754284AbcJPOUr (ORCPT ); Sun, 16 Oct 2016 10:20:47 -0400 Received: from hacbook.lan (dslb-188-104-195-177.188.104.pools.vodafone-ip.de [188.104.195.177]) by mx.zohomail.com with SMTPS id 1476627602742545.5318365550297; Sun, 16 Oct 2016 07:20:02 -0700 (PDT) Message-ID: <1476627597.1752.3.camel@mniewoehner.de> Subject: Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422 From: Michael =?ISO-8859-1?Q?Niew=F6hner?= To: Felipe Balbi Cc: Vivek Gautam , Alim Akhtar , Pankaj Dubey , Anand Moon , Mathias Nyman , Greg Kroah-Hartman , Kukjin Kim , Krzysztof Kozlowski , Linux USB Mailing List , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Vivek Gautam In-Reply-To: <1475871962.1697.12.camel@mniewoehner.de> References: <1472414695.3845.3.camel@mniewoehner.de> <87lgzgdof3.fsf@linux.intel.com> <57C41582.1030604@linux.intel.com> <1472468730.4925.3.camel@mniewoehner.de> <1475578687.1912.28.camel@mniewoehner.de> <1475771380.22019.5.camel@mniewoehner.de> <87y420wqoy.fsf@linux.intel.com> <1475871962.1697.12.camel@mniewoehner.de> Date: Sun, 16 Oct 2016 16:19:57 +0200 Mime-Version: 1.0 X-Mailer: Evolution 3.22.2 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Felipe, On Fri, 2016-10-07 at 22:26 +0200, Michael Niewöhner wrote: > Hi Felipe, > > On Fr, 2016-10-07 at 10:42 +0300, Felipe Balbi wrote: > > Hi, > > > > Michael Niewöhner writes: > > > > > > > > > > > The clocks are same across working/non-working. > > > > Is it possible to bisect the commit that's causing hang for 4.8x ? > > > > > > > > > [c499ff71ff2a281366c6ec7a904c547d806cbcd1] usb: dwc3: core: re-factor init and exit paths > > > This patch causes both the hang on reboot and the lsusb hang. > > > > How to reproduce? Why don't we see this on x86 and TI boards? I'm > > guessing this is failed bisection, as I can't see anything in that > > commit that would cause reboot hang. Also, that code path is *NOT* > > executed when you run lsusb. > > > > I've tested this procedure multiple times to be sure: > > - checkout c499ff71, compile, boot the odroid > - run lsusb -v => lsusb hangs, can't terminate with ctrl-c > - hard reset, after boot run poweroff or reboot => board does not completely power off / reboot (see log below) > - revert c499ff71, mrproper, compile, boot the odroid > - run lsusb -v => shows full output, not hanging > - run reboot or poweroff => board powers off / reboots just fine > > > dmesg poweroff not working: > ... > [  120.733519] systemd-journald[144]: systemd-journald stopped as pid 144        > [  120.742663] systemd-shutdown[1]: Sending SIGKILL to remaining processes...    > [  120.769212] systemd-shutdown[1]: Unmounting file systems.                     > [  120.773713] systemd-shutdown[1]: Unmounting /sys/kernel/debug.                > [  120.827211] systemd-shutdown[1]: Unmounting /dev/mqueue.                      > [  121.081672] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     > [  121.091687] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     > [  121.095608] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     > [  121.101014] systemd-shutdown[1]: All filesystems unmounted.                   > [  121.106523] systemd-shutdown[1]: Deactivating swaps.                          > [  121.111585] systemd-shutdown[1]: All swaps deactivated.                       > [  121.116661] systemd-shutdown[1]: Detaching loop devices.                      > [  121.126395] systemd-shutdown[1]: All loop devices detached.                   > [  121.130525] systemd-shutdown[1]: Detaching DM devices.                        > [  121.135824] systemd-shutdown[1]: All DM devices detached.                     > [  121.166327] systemd-shutdown[1]: /lib/systemd/system-shutdown succeeded.      > [  121.171739] systemd-shutdown[1]: Powering off. > > => at this point removing the sd card would show a message  > "removed mmc0" (not sure what the real message was...) so the board is not completely off. > > > dmesg poweroff working: > ... > [  120.733519] systemd-journald[144]: systemd-journald stopped as pid 144        > [  120.742663] systemd-shutdown[1]: Sending SIGKILL to remaining processes...    > [  120.769212] systemd-shutdown[1]: Unmounting file systems.                     > [  120.773713] systemd-shutdown[1]: Unmounting /sys/kernel/debug.                > [  120.827211] systemd-shutdown[1]: Unmounting /dev/mqueue.                      > [  121.081672] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     > [  121.091687] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     > [  121.095608] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                     > [  121.101014] systemd-shutdown[1]: All filesystems unmounted.                   > [  121.106523] systemd-shutdown[1]: Deactivating swaps.                          > [  121.111585] systemd-shutdown[1]: All swaps deactivated.                       > [  121.116661] systemd-shutdown[1]: Detaching loop devices.                      > [  121.126395] systemd-shutdown[1]: All loop devices detached.                   > [  121.130525] systemd-shutdown[1]: Detaching DM devices.                        > [  121.135824] systemd-shutdown[1]: All DM devices detached.                     > [  121.166327] systemd-shutdown[1]: /lib/systemd/system-shutdown succeeded.      > [  121.171739] systemd-shutdown[1]: Powering off. > [  121.182331] rebo� > > > > Best regards > Michael Niewöhner I did some more tests with next-20161016. Reverting / commenting out one part of your patch "solves" the lsusb hang, the reboot problem and also the "debounce failed" message. [1] Another "solution" is to call phy_power_off before phy_power_on. [2] Disclaimer: I have no idea what I was doing ;-) These were just some simple trial-and-error attempts that maybe help to find the real cause of the problems. [1] Best regards Michael diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 7287a76..5ef589d 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -724,6 +724,7 @@ static int dwc3_core_init(struct dwc3 *dwc)   /* Adjust Frame Length */   dwc3_frame_length_adjustment(dwc);   +/*   usb_phy_set_suspend(dwc->usb2_phy, 0);   usb_phy_set_suspend(dwc->usb3_phy, 0);   ret = phy_power_on(dwc->usb2_generic_phy); @@ -733,6 +734,7 @@ static int dwc3_core_init(struct dwc3 *dwc)   ret = phy_power_on(dwc->usb3_generic_phy);   if (ret < 0)   goto err3; +*/     ret = dwc3_event_buffers_setup(dwc);   if (ret) { [2] diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 7287a76..f6c8e13 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -726,6 +726,8 @@ static int dwc3_core_init(struct dwc3 *dwc)           usb_phy_set_suspend(dwc->usb2_phy, 0);         usb_phy_set_suspend(dwc->usb3_phy, 0); +       phy_power_off(dwc->usb2_generic_phy); +       phy_power_off(dwc->usb3_generic_phy);         ret = phy_power_on(dwc->usb2_generic_phy);         if (ret < 0)                 goto err2;