From patchwork Wed Nov 2 11:11:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 9408939 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 781296022E for ; Wed, 2 Nov 2016 11:12:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 69FE529C88 for ; Wed, 2 Nov 2016 11:12:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5EDE929E23; Wed, 2 Nov 2016 11:12:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C42E29C88 for ; Wed, 2 Nov 2016 11:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751111AbcKBLMW (ORCPT ); Wed, 2 Nov 2016 07:12:22 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:44380 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbcKBLMW (ORCPT ); Wed, 2 Nov 2016 07:12:22 -0400 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OG000F4RHRY5Z00@mailout2.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 02 Nov 2016 20:11:58 +0900 (KST) X-AuditID: cbfee61b-f793d6d000005a2a-f8-5819c9fd599a Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 95.B6.23082.DF9C9185; Wed, 2 Nov 2016 20:11:58 +0900 (KST) Received: from AMDC3061.digital.local ([106.116.147.40]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OG0001X0HRPYQB0@mmp1.samsung.com>; Wed, 02 Nov 2016 20:11:57 +0900 (KST) From: Sylwester Nawrocki To: broonie@kernel.org Cc: krzk@kernel.org, m.szyprowski@samsung.com, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, sbkim73@samsung.com, Sylwester Nawrocki Subject: [PATCH] ASoC: samsung: s2c24xx-i2s: remove redundant error message Date: Wed, 02 Nov 2016 12:11:47 +0100 Message-id: <1478085107-30865-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t9jAd1/JyUjDI7OYbK4cvEQk8XUh0/Y LM6f38BuMeP8PiaLtUfuslscftPOanFxxRcmB3aPDZ+b2Dw2repk8+jbsorR4/MmuQCWKDeb jNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nb JbhlfFihVTCJo2LtnenMDYxv2LoYOTkkBEwkfr99xwRhi0lcuLceLC4ksJRRYu479y5GLiD7 F6PEh5s3wBJsAoYSvUf7GEFsEaCG23M6mUFsZoHNjBItq5JAbGEBb4m5y7azgNgsAqoSDTNP gtXwCrhJnD89D2qZnMTJY5NZJzByL2BkWMUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kR HJbPpHcwHt7lfohRgINRiYe34LJEhBBrYllxZe4hRgkOZiUR3lWHJSOEeFMSK6tSi/Lji0pz UosPMZoCHTCRWUo0OR8YM3kl8YYm5ibmxgYW5paWJkZK4ryNs5+FCwmkJ5akZqemFqQWwfQx cXBKNTCyGtmu+qF42/OWtO3tfXfT7F7ahB9RFvcV8Hwvn1rcvfKfwwf5sCMnT34/fHJi0Vq9 T0rHb1+Tm5Py+MiXXR2PNbkneR5ov5a4jY/VS7Xu7kuevWs6v6bUrNCXP/hBv7/vzsvG4EU3 Jk9OeX3HQO30BJEb/j4vuF9tSsn8/fro4g0f7GNyXs2apMRSnJFoqMVcVJwIAKxvhPthAgAA X-MTR: 20000000000000000@CPGS Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no need to report the resource request error in the driver as it is already handled within devm_ioremap_resource(). While at it also drop a redundant variable initialization. Signed-off-by: Sylwester Nawrocki --- sound/soc/samsung/s3c24xx-i2s.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c index bc5809a..07f5091 100644 --- a/sound/soc/samsung/s3c24xx-i2s.c +++ b/sound/soc/samsung/s3c24xx-i2s.c @@ -426,13 +426,9 @@ static int s3c24xx_i2s_resume(struct snd_soc_dai *cpu_dai) static int s3c24xx_iis_dev_probe(struct platform_device *pdev) { struct resource *res; - int ret = 0; + int ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Can't get IO resource.\n"); - return -ENOENT; - } s3c24xx_i2s.regs = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(s3c24xx_i2s.regs)) return PTR_ERR(s3c24xx_i2s.regs);