From patchwork Fri Nov 4 07:58:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 9412059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A03060722 for ; Fri, 4 Nov 2016 07:58:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C90E2B09D for ; Fri, 4 Nov 2016 07:58:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 812B92B0A1; Fri, 4 Nov 2016 07:58:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6CDCE2B09D for ; Fri, 4 Nov 2016 07:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760199AbcKDH6X (ORCPT ); Fri, 4 Nov 2016 03:58:23 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:52826 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760190AbcKDH6W (ORCPT ); Fri, 4 Nov 2016 03:58:22 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OG300FT0Y56MT70@mailout3.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 04 Nov 2016 07:58:18 +0000 (GMT) Received: from eusmges5.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20161104075818eucas1p291af223546ae7220343ae0589a480902~DyS0jSb__2904029040eucas1p2G; Fri, 4 Nov 2016 07:58:18 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges5.samsung.com (EUCPMTA) with SMTP id FD.3F.19540.A9F3C185; Fri, 4 Nov 2016 07:58:18 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20161104075817eucas1p2fe178b13386ff0e03592d2a2094c0ac0~DySzveWQt2870928709eucas1p24; Fri, 4 Nov 2016 07:58:17 +0000 (GMT) X-AuditID: cbfec7f5-f79ce6d000004c54-61-581c3f9a1073 Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8B.4A.07726.59F3C185; Fri, 4 Nov 2016 07:58:13 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OG300MNXY522Z50@eusync1.samsung.com>; Fri, 04 Nov 2016 07:58:17 +0000 (GMT) From: Marek Szyprowski To: iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski Subject: [PATCH RESEND] iommu/exynos: Improve page fault debug message Date: Fri, 04 Nov 2016 08:58:09 +0100 Message-id: <1478246289-21525-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWy7djP87qz7GUiDJ585bRYsN/aYsb5fUwW a4/cZXdg9ph8YzmjR9+WVYwenzfJBTBHcdmkpOZklqUW6dslcGX8PP+OveAmd8X5TVtYGhg/ cHYxcnJICJhIrH+0iwXCFpO4cG89G4gtJLCUUWJvu14XIxeQ/ZlRYtL8f0wwDRuO3WeDSCxj lHi9bzEThNPAJNH58y1YFZuAoUTX2y6wUSIC7hLX/zwHW8EsoC+xbuFWsBphATeJfweXg9Ww CKhKTL7byAhi8wp4SCw41Qx1kpzEyWOTWUEWSAisYJO43bgaqJkDyJGV2HSAGaLGRWJaz3+o emGJV8e3sEPYMhKdHQehru5nlGhq1YawZzBKnHvLC2FbSxw+fpEV4jY+iUnbpjNDjOeV6GgT gijxkPhzr50VwnaUeNF3CxpCsRLPv/xjn8AovYCRYRWjSGppcW56arGpXnFibnFpXrpecn7u JkZgnJ3+d/zrDsalx6wOMQpwMCrx8M7wk44QYk0sK67MPcQowcGsJMK7x04mQog3JbGyKrUo P76oNCe1+BCjNAeLkjjvngVXwoUE0hNLUrNTUwtSi2CyTBycUg2MbuvuCHzK5FaTsq76JMl7 MDr8mJyrSJlLx6uHUhY2usuniMYx3T+ruf/7/KcKD/p28czUnqclsPX7p9MLT29tPLoueMqf E/4+d4IsZk6duclhX5Tr1NA1jtnfXBfEhh8Ru2Zy85vmnh6TxVvn8E3kiPaY+dFO5OdJBs6n n6WTrHZdqnXmPVF+RImlOCPRUIu5qDgRABgF0jOvAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrILMWRmVeSWpSXmKPExsVy+t/xy7pT7WUiDFbMEbVYsN/aYsb5fUwW a4/cZXdg9ph8YzmjR9+WVYwenzfJBTBHudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam 2ipF6PqGBCkplCXmlAJ5RgZowME5wD1YSd8uwS3j5/l37AU3uSvOb9rC0sD4gbOLkZNDQsBE YsOx+2wQtpjEhXvrgWwuDiGBJYwS984fYARJCAk0MUlcadMHsdkEDCW63naBNYgIuEtc//Oc BcRmFtCXWLdwKxOILSzgJvHv4HKwGhYBVYnJdxvB5vAKeEgsONXMArFMTuLkscmsExi5FzAy rGIUSS0tzk3PLTbUK07MLS7NS9dLzs/dxAgMrm3Hfm7ewXhpY/AhRgEORiUe3hl+0hFCrIll xZW5hxglOJiVRHjZrWQihHhTEiurUovy44tKc1KLDzGaAi2fyCwlmpwPDPy8knhDE0NzS0Mj YwsLcyMjJXHekg9XwoUE0hNLUrNTUwtSi2D6mDg4pRoYWTlDZjYa9tW9KG7ZUJp0+Jf9QtOA q6e9jE+dWLvpXpLD7LdPDLsKq0wbks2NEkRWHPFbucXLyHvDzFuKjTXO/Gyi//qmN6leDstY z32LWaj3fO3q+Truz/X+TRdQfyaZ6B68jHP7EqmFZxU9PF4+Y9u1its1tcgt2Dv837XfQY9D qs33ascpsRRnJBpqMRcVJwIA9pGTnkQCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161104075817eucas1p2fe178b13386ff0e03592d2a2094c0ac0 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161104075817eucas1p2fe178b13386ff0e03592d2a2094c0ac0 X-RootMTR: 20161104075817eucas1p2fe178b13386ff0e03592d2a2094c0ac0 References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add master device name to default IOMMU fault message to make easier to find which device triggered the fault. While at it, move printing some information (like page table base and first level entry addresses) to dev_dbg(), because those are typically not very useful for typical device driver user/developer not equipped with hardware debugging tools. Signed-off-by: Marek Szyprowski Reviewed-by: Javier Martinez Canillas --- drivers/iommu/exynos-iommu.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 30808e9..47f0d67 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -368,13 +368,14 @@ static void show_fault_information(struct sysmmu_drvdata *data, { sysmmu_pte_t *ent; - dev_err(data->sysmmu, "%s FAULT occurred at %#x (page table base: %pa)\n", - finfo->name, fault_addr, &data->pgtable); + dev_err(data->sysmmu, "%s: %s FAULT occurred at %#x\n", + dev_name(data->master), finfo->name, fault_addr); + dev_dbg(data->sysmmu, "Page table base: %pa\n", &data->pgtable); ent = section_entry(phys_to_virt(data->pgtable), fault_addr); - dev_err(data->sysmmu, "\tLv1 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\tLv1 entry: %#x\n", *ent); if (lv1ent_page(ent)) { ent = page_entry(ent, fault_addr); - dev_err(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); + dev_dbg(data->sysmmu, "\t Lv2 entry: %#x\n", *ent); } }