| Message ID | 1478513376-14307-7-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote: > Extend the S3C RTC node with rtc_src clock so it could be operational. > The rtc_src clock is provided by MAX8997. > > CC: Rob Herring <robh+dt@kernel.org> > CC: devicetree@vger.kernel.org > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On Mon, Nov 07, 2016 at 03:39:36PM +0530, Pankaj Dubey wrote: > Extend the S3C RTC node with rtc_src clock so it could be operational. > The rtc_src clock is provided by MAX8997. > > CC: Rob Herring <robh+dt@kernel.org> > CC: devicetree@vger.kernel.org > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > arch/arm/boot/dts/exynos4210-origen.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts > index 6c7ef4e..4cac9b6 100644 > --- a/arch/arm/boot/dts/exynos4210-origen.dts > +++ b/arch/arm/boot/dts/exynos4210-origen.dts > @@ -18,6 +18,7 @@ > #include "exynos4210.dtsi" > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > +#include <dt-bindings/clock/maxim,max8997.h> Just a nit: put the system-wide includes in alphabetical order, so clock, gpio and finally input. It helps reducing conflicting changes (when more people add includes in the same time). Beside that, looks good, but it requires a dt-bindings in separate patch so I could pull it. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts index 6c7ef4e..4cac9b6 100644 --- a/arch/arm/boot/dts/exynos4210-origen.dts +++ b/arch/arm/boot/dts/exynos4210-origen.dts @@ -18,6 +18,7 @@ #include "exynos4210.dtsi" #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/clock/maxim,max8997.h> #include "exynos-mfc-reserved-memory.dtsi" / { @@ -324,6 +325,8 @@ &rtc { status = "okay"; + clocks = <&clock CLK_RTC>, <&max8997 MAX8997_CLK_AP>; + clock-names = "rtc", "rtc_src"; }; &tmu {
Extend the S3C RTC node with rtc_src clock so it could be operational. The rtc_src clock is provided by MAX8997. CC: Rob Herring <robh+dt@kernel.org> CC: devicetree@vger.kernel.org Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- arch/arm/boot/dts/exynos4210-origen.dts | 3 +++ 1 file changed, 3 insertions(+)