| Message ID | 1479301615-11240-6-git-send-email-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Marek, 2016-11-16 22:06 GMT+09:00 Marek Szyprowski <m.szyprowski@samsung.com>: > UART3 device is not really needed for enabling audio block on TM2. > Enabling it made it working by enabling some common parent clocks, > what is now handled by improved exynos5433 clocks driver. Thus the UART3 > device node can be safetly disabled. The assigned-clocks entries are > however still needed, so move them under the respective CMU node. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 506f8ab..5ab1028 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -891,10 +891,9 @@ > status = "okay"; > }; > > -&serial_3 { > +&cmu_aud { > assigned-clocks = <&cmu_aud CLK_MOUT_AUD_PLL_USER>; > assigned-clock-parents = <&cmu_top CLK_FOUT_AUD_PLL>; > - status = "okay"; > }; Looks good to me. The UART3 of TM2 was used for bluetooth device. CLK_MOUT_AUD_PLL_USER clock is the parent clock of CLK_SCLK_AUD_UART of uart3 for bluetooth. So, in the legacy, we assigned the parent clock in the uart3 Device-tree node. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chanwoo, On 2016-11-16 17:51, Chanwoo Choi wrote: > Hi Marek, > > 2016-11-16 22:06 GMT+09:00 Marek Szyprowski <m.szyprowski@samsung.com>: >> UART3 device is not really needed for enabling audio block on TM2. >> Enabling it made it working by enabling some common parent clocks, >> what is now handled by improved exynos5433 clocks driver. Thus the UART3 >> device node can be safetly disabled. The assigned-clocks entries are >> however still needed, so move them under the respective CMU node. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index 506f8ab..5ab1028 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -891,10 +891,9 @@ >> status = "okay"; >> }; >> >> -&serial_3 { >> +&cmu_aud { >> assigned-clocks = <&cmu_aud CLK_MOUT_AUD_PLL_USER>; >> assigned-clock-parents = <&cmu_top CLK_FOUT_AUD_PLL>; >> - status = "okay"; >> }; > > Looks good to me. > > The UART3 of TM2 was used for bluetooth device. CLK_MOUT_AUD_PLL_USER > clock is the parent clock of CLK_SCLK_AUD_UART of uart3 for bluetooth. > So, in the legacy, we assigned the parent clock in the uart3 > Device-tree node. > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Selecting AUD_PLL as a parent affects the whole audio block and it is needed to get it working, so it is not only related to bluetooth device. Best regards
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 506f8ab..5ab1028 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -891,10 +891,9 @@ status = "okay"; }; -&serial_3 { +&cmu_aud { assigned-clocks = <&cmu_aud CLK_MOUT_AUD_PLL_USER>; assigned-clock-parents = <&cmu_top CLK_FOUT_AUD_PLL>; - status = "okay"; }; &cmu_fsys {
UART3 device is not really needed for enabling audio block on TM2. Enabling it made it working by enabling some common parent clocks, what is now handled by improved exynos5433 clocks driver. Thus the UART3 device node can be safetly disabled. The assigned-clocks entries are however still needed, so move them under the respective CMU node. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)