From patchwork Thu Dec 1 04:40:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shailendra.v@samsung.com X-Patchwork-Id: 9455351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EE6DC60235 for ; Thu, 1 Dec 2016 04:43:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E400528497 for ; Thu, 1 Dec 2016 04:43:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D8A9C284C8; Thu, 1 Dec 2016 04:43:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1285C284BF for ; Thu, 1 Dec 2016 04:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758124AbcLAEmx (ORCPT ); Wed, 30 Nov 2016 23:42:53 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:33046 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbcLAEmw (ORCPT ); Wed, 30 Nov 2016 23:42:52 -0500 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OHH00H2TP3DWDD0@mailout2.samsung.com>; Thu, 01 Dec 2016 13:42:49 +0900 (KST) X-AuditID: cbfee61b-f796f6d000004092-76-583faa4950f7 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id D2.D3.16530.94AAF385; Thu, 1 Dec 2016 13:42:49 +0900 (KST) Received: from localhost.localdomain ([107.108.168.37]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OHH00BZGP2XLFA0@mmp2.samsung.com>; Thu, 01 Dec 2016 13:42:49 +0900 (KST) From: Shailendra Verma To: Mauro Carvalho Chehab , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Sylwester Nawrocki , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Platform: Exynos4-is: Clean up file handle in open() error path. Date: Thu, 01 Dec 2016 10:10:22 +0530 Message-id: <1480567222-12829-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsVy+t9jQV3PVfYRBgsPKVu8ebuGyaL/8Wtm i/PnN7BbnG16w26x6fE1VovLu+awWfRs2MpqMeP8PiaLZZv+MFkcftPOanFr3kw2i0XfXjFb /L14ic2B12PnrLvsHptWdbJ5bF5S77GlH8jr27KK0ePzJrkAtig3m4zUxJTUIoXUvOT8lMy8 dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZZw9NZW1YBFbxf37 z1kaGNexdjFyckgImEi035nIDGGLSVy4t56ti5GLQ0hgFqPEt/8LmCCcn4wSD1r62UCq2AQM JV73/QVLiAh8ZJb4cHkvO0iCWUBGYt/ENqAEB4ewQLDEm1uWIGEWAVWJX/ffg/XyCnhIrP21 gw2kREJAQWLOJJsJjNwLGBlWMUqkFiQXFCel5xrlpZbrFSfmFpfmpesl5+duYgSH+TPpHYyH d7kfYhTgYFTi4d1x1y5CiDWxrLgy9xCjBAezkgiv7Ur7CCHelMTKqtSi/Pii0pzU4kOMpkD7 JzJLiSbnA2MwryTe0MTcxNzYwMLc0tLESEmct3H2s3AhgfTEktTs1NSC1CKYPiYOTqkGRn73 mmeNHPfct5XF1eyUfWi95PCN9/ceTeE/8MnVjTdC5muQyo/aJ6suF6+72Sn73LRdU0ZRMy+m 0tJzT3Y1+7b8uTs1Ds22vbnqdcJRjmcyEyTCuxdq322bGfS91bIqcv6NxdNL9x5xuz3B631G WnFJg9yKD1Fcf4yUqv21Xym9zWy/G6I5X4mlOCPRUIu5qDgRABdWuUaJAgAA X-MTR: 20000000000000000@CPGS Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The File handle is not yet added in the vfd list.So no need to call v4l2_fh_del(&ctx->fh) if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/exynos4-is/fimc-m2m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-m2m.c b/drivers/media/platform/exynos4-is/fimc-m2m.c index 6028e4f..d8724fe 100644 --- a/drivers/media/platform/exynos4-is/fimc-m2m.c +++ b/drivers/media/platform/exynos4-is/fimc-m2m.c @@ -663,8 +663,8 @@ static int fimc_m2m_open(struct file *file) v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); error_c: fimc_ctrls_delete(ctx); -error_fh: v4l2_fh_del(&ctx->fh); +error_fh: v4l2_fh_exit(&ctx->fh); kfree(ctx); unlock: