| Message ID | 1483629943-31183-3-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello Andrzej, On 01/05/2017 12:25 PM, Andrzej Hajda wrote: > TV path consist of following interconnected components: > - DECON_TV - display controller, > - HDMI - video signal converter RGB / HDMI, > - MHL - video signal converter HDMI / MHL, > - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). > > The same path/configuration is used by TM2E board and is > automatically applied thanks to dts file inclusion. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 71 +++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts [snip] > > +&hdmi { > + hpd-gpio = <&gpa3 0 0>; Same comment than interrupts, please use the GPIO_ACTIVE_HIGH here. The rest looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
Hi Andrzej, On Thu, Jan 05, 2017 at 04:25:43PM +0100, Andrzej Hajda wrote: > TV path consist of following interconnected components: > - DECON_TV - display controller, > - HDMI - video signal converter RGB / HDMI, > - MHL - video signal converter HDMI / MHL, > - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). > > The same path/configuration is used by TM2E board and is > automatically applied thanks to dts file inclusion. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 71 +++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 060adbf..0a87670 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts same here, this patch will conflict with the previous patches on the exynos5433-tm2.dts Could you please rebase them on top of this one: https://lkml.org/lkml/2017/1/5/887 which is rebased on top of: https://lkml.org/lkml/2016/12/29/319 Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 060adbf..0a87670 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -236,6 +236,22 @@ }; }; +&decon_tv { + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + tv_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_tv>; + }; + }; + }; +}; + &dsi { status = "okay"; vddcore-supply = <&ldo6_reg>; @@ -294,6 +310,33 @@ }; }; +&hdmi { + hpd-gpio = <&gpa3 0 0>; + status = "okay"; + vdd-supply = <&ldo6_reg>; + vdd_osc-supply = <&ldo7_reg>; + vdd_pll-supply = <&ldo6_reg>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + hdmi_to_tv: endpoint { + remote-endpoint = <&tv_to_hdmi>; + }; + }; + + port@1 { + reg = <1>; + hdmi_to_mhl: endpoint { + remote-endpoint = <&mhl_to_hdmi>; + }; + }; + }; +}; + &hsi2c_0 { status = "okay"; clock-frequency = <2500000>; @@ -708,6 +751,30 @@ }; }; +&hsi2c_7 { + status = "okay"; + + sii8620@39 { + reg = <0x39>; + compatible = "sil,sii8620"; + cvcc10-supply = <&ldo36_reg>; + iovcc18-supply = <&ldo34_reg>; + interrupt-parent = <&gpf0>; + interrupts = <2 0>; + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>; + clocks = <&pmu_system_controller 0>; + clock-names = "xtal"; + assigned-clocks = <&pmu_system_controller 0>; + assigned-clock-parents = <&xxti>; + + port { + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; + }; + }; +}; + &hsi2c_8 { status = "okay"; @@ -751,6 +818,10 @@ }; }; +&hsi2c_11 { + status = "okay"; +}; + &i2s0 { status = "okay"; };
TV path consist of following interconnected components: - DECON_TV - display controller, - HDMI - video signal converter RGB / HDMI, - MHL - video signal converter HDMI / MHL, - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). The same path/configuration is used by TM2E board and is automatically applied thanks to dts file inclusion. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 71 +++++++++++++++++++++++++++ 1 file changed, 71 insertions(+)