From patchwork Mon Jan 9 14:03:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 9504853 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95F4E60757 for ; Mon, 9 Jan 2017 14:05:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87CA21FE6A for ; Mon, 9 Jan 2017 14:05:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B2C7284E6; Mon, 9 Jan 2017 14:05:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D7E11FE6A for ; Mon, 9 Jan 2017 14:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967108AbdAIOEt (ORCPT ); Mon, 9 Jan 2017 09:04:49 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:32383 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942376AbdAIODa (ORCPT ); Mon, 9 Jan 2017 09:03:30 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OJI00HOLN1P9R70@mailout2.w1.samsung.com>; Mon, 09 Jan 2017 14:03:26 +0000 (GMT) Received: from eusmges3.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170109140326eucas1p152d20737f0c07970eab6a8577a715c5a~YH2dl8gvG2903929039eucas1p1T; Mon, 9 Jan 2017 14:03:26 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3.samsung.com (EUCPMTA) with SMTP id 2F.F5.09557.D2893785; Mon, 9 Jan 2017 14:03:25 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170109140325eucas1p2674704b2505517ee532284c58c8a64d1~YH2c_DtQG1473714737eucas1p2Y; Mon, 9 Jan 2017 14:03:25 +0000 (GMT) X-AuditID: cbfec7f2-f790f6d000002555-6b-5873982da2d9 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 5D.2D.06687.F5893785; Mon, 9 Jan 2017 14:04:15 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OJI005JBN1K8V20@eusync3.samsung.com>; Mon, 09 Jan 2017 14:03:25 +0000 (GMT) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Cc: Marek Szyprowski , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Vinod Koul , Ulf Hansson , "Rafael J. Wysocki" , Inki Dae Subject: [PATCH v2 1/4] dmaengine: pl330: remove pdata based initialization Date: Mon, 09 Jan 2017 15:03:15 +0100 Message-id: <1483970598-6191-2-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1483970598-6191-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsWy7djPc7q6M4ojDPb1mltsnLGe1WL11L+s FpPuT2CxOH9+A7vFpsfXWC0+9x5htJhxfh+Txdojd9ktzpy+xGpxfG24xcu+/SwO3B6L97xk 8ti0qpPN4861PWwem5fUe2y52s7i0bdlFaPH501yAexRXDYpqTmZZalF+nYJXBlLZmoV3FSu WPvpB1sD4w7ZLkYODgkBE4mTZ1K7GDmBTDGJC/fWs3UxcnEICSxllLg76SErhPOZUeLKvW2M MA3fZkdAxJcxSjxd1ckC4TQwSey6d5cRZBSbgKFE19susFEiAk2MEm/nL2cEcZgFljJJbG5/ yQ5SJSzgLdF1ZTJYB4uAqsTno3fB4rwC7hJ33mxnhzhKTuLkscmsIDangIfE5xUzwdZJCMxj l1h0v50J4iZZiU0HmCHqXSTWfHvPCGELS7w6vgVqjoxEZ8dBJgi7n1GiqVUbwp7BKHHuLS+E bS1x+PhFsF3MAnwSk7ZNZ4YYzyvR0SYEUeIhsWH+GVYI21Hi+cSfUN/PZpQ48fox0wRGmQWM DKsYRVJLi3PTU4uN9YoTc4tL89L1kvNzNzEC4/70v+OfdjB+PWF1iFGAg1GJh3fDpOIIIdbE suLK3EOMEhzMSiK8N6YAhXhTEiurUovy44tKc1KLDzFKc7AoifPuWXAlXEggPbEkNTs1tSC1 CCbLxMEp1cAocU3Wy3i7cj7nq+l9lWWM9ifubEnf8XtzMl/w3n2+Bx9E/99/U2ejZv/Tt09K 02SkZnT290Vff/LgSb3M4tBXwRcW/Nt9+uXZ2WWsRc8zJHr4ipoFRJ2X7DD+euPBswN7pC+k bxeM2K8fneVWmiG+fOnlB6oZU+SDyv7K2Uw5+cC/6/MhO2F7JZbijERDLeai4kQAgIVPO/cC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42I5/e/4Vd34GcURBh33zC02zljParF66l9W i0n3J7BYnD+/gd1i0+NrrBafe48wWsw4v4/JYu2Ru+wWZ05fYrU4vjbc4mXffhYHbo/Fe14y eWxa1cnmcefaHjaPzUvqPbZcbWfx6NuyitHj8ya5APYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQ N10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgHuAcr6dsluGUsmalVcFO5Yu2nH2wNjDtk uxg5OCQETCS+zY7oYuQEMsUkLtxbz9bFyMUhJLCEUeLz3fdMEE4Tk8Si2XOYQKrYBAwlut52 sYHYIgJNjBIHf3mAFDELLGeS2DL9AjtIQljAW6LrymRGEJtFQFXi89G7YHFeAXeJO2+2s0Os k5M4eWwyK4jNKeAh8XnFTBYQWwiopuPtc/YJjLwLGBlWMYqklhbnpucWG+oVJ+YWl+al6yXn 525iBMbAtmM/N+9gvLQx+BCjAAejEg/vhknFEUKsiWXFlbmHGCU4mJVEeG9MAQrxpiRWVqUW 5ccXleakFh9iNAU6aiKzlGhyPjA+80riDU0MzS0NjYwtLMyNjJTEeUs+XAkXEkhPLEnNTk0t SC2C6WPi4JRqYLTVjno9p1vZtOTpYxWXh7c2qgenFVuV+a/o1nK63FPdu7n99PO55mp7sop2 F12766cekuvXKBSn4lvb5hNqpJW5ObMjgb/3T1+ktm699X6nM+Xmkrc2P7x3/4mP6ZX27Rvk nf//+iceqOz4fpokQ8y6F+kmS4N6RPiND5XPqEgIsa5buz9IiaU4I9FQi7moOBEAVK92XJcC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170109140325eucas1p2674704b2505517ee532284c58c8a64d1 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170109140325eucas1p2674704b2505517ee532284c58c8a64d1 X-RootMTR: 20170109140325eucas1p2674704b2505517ee532284c58c8a64d1 References: <1483970598-6191-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This driver is now used only on platforms which support device tree, so it is safe to remove legacy platform data based initialization code. Signed-off-by: Marek Szyprowski --- drivers/dma/pl330.c | 30 ++++++++---------------------- include/linux/amba/pl330.h | 35 ----------------------------------- 2 files changed, 8 insertions(+), 57 deletions(-) delete mode 100644 include/linux/amba/pl330.h diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 740bbb942594..27cc5d29ac2c 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include @@ -2839,7 +2838,6 @@ static int __maybe_unused pl330_resume(struct device *dev) static int pl330_probe(struct amba_device *adev, const struct amba_id *id) { - struct dma_pl330_platdata *pdat; struct pl330_config *pcfg; struct pl330_dmac *pl330; struct dma_pl330_chan *pch, *_p; @@ -2849,8 +2847,6 @@ static int __maybe_unused pl330_resume(struct device *dev) int num_chan; struct device_node *np = adev->dev.of_node; - pdat = dev_get_platdata(&adev->dev); - ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); if (ret) return ret; @@ -2863,7 +2859,7 @@ static int __maybe_unused pl330_resume(struct device *dev) pd = &pl330->ddma; pd->dev = &adev->dev; - pl330->mcbufsz = pdat ? pdat->mcbuf_sz : 0; + pl330->mcbufsz = 0; /* get quirk */ for (i = 0; i < ARRAY_SIZE(of_quirks); i++) @@ -2907,10 +2903,7 @@ static int __maybe_unused pl330_resume(struct device *dev) INIT_LIST_HEAD(&pd->channels); /* Initialize channel parameters */ - if (pdat) - num_chan = max_t(int, pdat->nr_valid_peri, pcfg->num_chan); - else - num_chan = max_t(int, pcfg->num_peri, pcfg->num_chan); + num_chan = max_t(int, pcfg->num_peri, pcfg->num_chan); pl330->num_peripherals = num_chan; @@ -2922,11 +2915,8 @@ static int __maybe_unused pl330_resume(struct device *dev) for (i = 0; i < num_chan; i++) { pch = &pl330->peripherals[i]; - if (!adev->dev.of_node) - pch->chan.private = pdat ? &pdat->peri_id[i] : NULL; - else - pch->chan.private = adev->dev.of_node; + pch->chan.private = adev->dev.of_node; INIT_LIST_HEAD(&pch->submitted_list); INIT_LIST_HEAD(&pch->work_list); INIT_LIST_HEAD(&pch->completed_list); @@ -2939,15 +2929,11 @@ static int __maybe_unused pl330_resume(struct device *dev) list_add_tail(&pch->chan.device_node, &pd->channels); } - if (pdat) { - pd->cap_mask = pdat->cap_mask; - } else { - dma_cap_set(DMA_MEMCPY, pd->cap_mask); - if (pcfg->num_peri) { - dma_cap_set(DMA_SLAVE, pd->cap_mask); - dma_cap_set(DMA_CYCLIC, pd->cap_mask); - dma_cap_set(DMA_PRIVATE, pd->cap_mask); - } + dma_cap_set(DMA_MEMCPY, pd->cap_mask); + if (pcfg->num_peri) { + dma_cap_set(DMA_SLAVE, pd->cap_mask); + dma_cap_set(DMA_CYCLIC, pd->cap_mask); + dma_cap_set(DMA_PRIVATE, pd->cap_mask); } pd->device_alloc_chan_resources = pl330_alloc_chan_resources; diff --git a/include/linux/amba/pl330.h b/include/linux/amba/pl330.h deleted file mode 100644 index fe93758e8403..000000000000 --- a/include/linux/amba/pl330.h +++ /dev/null @@ -1,35 +0,0 @@ -/* linux/include/linux/amba/pl330.h - * - * Copyright (C) 2010 Samsung Electronics Co. Ltd. - * Jaswinder Singh - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - */ - -#ifndef __AMBA_PL330_H_ -#define __AMBA_PL330_H_ - -#include - -struct dma_pl330_platdata { - /* - * Number of valid peripherals connected to DMAC. - * This may be different from the value read from - * CR0, as the PL330 implementation might have 'holes' - * in the peri list or the peri could also be reached - * from another DMAC which the platform prefers. - */ - u8 nr_valid_peri; - /* Array of valid peripherals */ - u8 *peri_id; - /* Operational capabilities */ - dma_cap_mask_t cap_mask; - /* Bytes to allocate for MC buffer */ - unsigned mcbuf_sz; -}; - -extern bool pl330_filter(struct dma_chan *chan, void *param); -#endif /* __AMBA_PL330_H_ */