From patchwork Wed Mar 22 10:34:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 9638461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 17E3060327 for ; Wed, 22 Mar 2017 10:34:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECB8F272F9 for ; Wed, 22 Mar 2017 10:34:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E109528415; Wed, 22 Mar 2017 10:34:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 701B4272F9 for ; Wed, 22 Mar 2017 10:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934199AbdCVKet (ORCPT ); Wed, 22 Mar 2017 06:34:49 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:59498 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934139AbdCVKep (ORCPT ); Wed, 22 Mar 2017 06:34:45 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ON7002F7PDOWI00@mailout3.w1.samsung.com>; Wed, 22 Mar 2017 10:34:36 +0000 (GMT) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170322103435eucas1p1e8cf44ddf70403cc46f5402900d0f314~uLcq-vqCw2631826318eucas1p1A; Wed, 22 Mar 2017 10:34:35 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1.samsung.com (EUCPMTA) with SMTP id 68.3C.16908.D3352D85; Wed, 22 Mar 2017 10:34:37 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170322103434eucas1p201996d20d01cdca113b9764117ce6167~uLcqMYJkp0214502145eucas1p23; Wed, 22 Mar 2017 10:34:34 +0000 (GMT) X-AuditID: cbfec7ef-f79d26d00000420c-dd-58d2533d7584 Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 4D.CB.10233.94352D85; Wed, 22 Mar 2017 10:34:49 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ON700JMUPDI4L20@eusync2.samsung.com>; Wed, 22 Mar 2017 10:34:34 +0000 (GMT) From: Marek Szyprowski To: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Andrzej Hajda , Krzysztof Kozlowski , Inki Dae , Seung-Woo Kim Subject: [PATCH] media: s5p-mfc: Don't allocate codec buffers from pre-allocated region Date: Wed, 22 Mar 2017 11:34:28 +0100 Message-id: <1490178868-8673-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1490007402-30265-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsWy7djP87q2wZciDLb+trG4te4cq8Wk+xNY LM6f38Bu0bNhK6vFjPP7mCzWHrnLbnH4TTuQO/klmwOHx6ZVnWwefVtWMXp83iQXwBzFZZOS mpNZllqkb5fAldHf/JalYLJCRce+R6wNjBOkuxg5OSQETCQm3ellhLDFJC7cW8/WxcjFISSw jFGi9/gnJgjnM6PEnEmXWGA6Ln76CmaDVU07wwpR1MAk8b5hKhtIgk3AUKLrbReYLSLgJLFw 1l92kCJmge+MEt92n2YFSQgLREpsm36CCcRmEVCVWH2tB+wOXgF3iZ3zHkBtk5M4eWwyWD2n gKfEi+t/we6TEHjMJjF94iIghwPIkZXYdIAZot5F4sGUPVC9whKvjm9hh7BlJC5P7oaK9zNK NLVqQ9gzGCXOveWFsK0lDh+/CLaLWYBPYtK26cwQ43klOtqEIEo8JC7dXsIEYTtK3Dr1iQXi +TmMEm++XWeawCizgJFhFaNIamlxbnpqsaFecWJucWleul5yfu4mRmDcnv53/P0OxqfNIYcY BTgYlXh4FeQvRgixJpYVV+YeYpTgYFYS4fUPuhQhxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfv givhQgLpiSWp2ampBalFMFkmDk6pBsaCz7e3bQuoE7coXhzw89p5layE6QJchtdX3Z6+Q1Os /53ZElmLN9zht9oaflXmHazeL/3Nekr33zXMr3mbj/1aOyXhgJJizs5diZsFVuX/aN5gEn+l 3qaBa9/Rqcb3hJ9mbLB1isj0n8xhzLTkS1ynjcNTf6GpxwxqBCJ8qjxiI+s36mfwNCuxFGck GmoxFxUnAgBTdTK91wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xK7qewZciDOZu07e4te4cq8Wk+xNY LM6f38Bu0bNhK6vFjPP7mCzWHrnLbnH4TTuQO/klmwOHx6ZVnWwefVtWMXp83iQXwBzlZpOR mpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsE t4z+5rcsBZMVKjr2PWJtYJwg3cXIySEhYCJx8dNXFghbTOLCvfVsILaQwBJGiauvyroYuYDs JiaJuQuns4Mk2AQMJbredoEViQg4SSyc9RcszizwnVFi2c00EFtYIFJi2/QTTCA2i4CqxOpr PYwgNq+Au8TOeQ+glslJnDw2mRXE5hTwlHhx/S/UYg+JdZ8nMk1g5F3AyLCKUSS1tDg3PbfY SK84Mbe4NC9dLzk/dxMjMIC3Hfu5ZQdj17vgQ4wCHIxKPLwK8hcjhFgTy4orcw8xSnAwK4nw JvleihDiTUmsrEotyo8vKs1JLT7EaAp01ERmKdHkfGB05ZXEG5oYmlsaGhlbWJgbGSmJ8079 cCVcSCA9sSQ1OzW1ILUIpo+Jg1OqgVGnbsrdo+VLaq4lGoZcZzdMUBLTY3Ot2nQ0b0NfkRTX tlUb2mqv/LDMDtio+2KDa8Gzfyv2FbWnd/azrFPewDT9lpIiy6S+V3orNOL1+hn3ss7tV/rV dihpZ3LbXrPy1zl+PN8Nd66q12lexPk45NWJ9tDoRR2ce97HmUdldtuv/czLd0ZvshJLcUai oRZzUXEiAJ0ohy12AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170322103434eucas1p201996d20d01cdca113b9764117ce6167 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170322103434eucas1p201996d20d01cdca113b9764117ce6167 X-RootMTR: 20170322103434eucas1p201996d20d01cdca113b9764117ce6167 References: <1490007402-30265-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Further investigation revealed that codec buffers also don't need to be allocated at higher addresses than firmware base for MFC v6+ hardware. Those buffers can be quite large and its size depends on the selected format and framesize. This patch changes the way the codec buffers are allocated - driver will use generic allocator for them instead of the pre-allocated buffer for firmware and contexts. Signed-off-by: Marek Szyprowski --- This patch should solve failure of h264 encoding due to insufficient memory for codec temporary buffers. Please consider it as part of "[PATCH v3 00/16] Exynos MFC v6+ - remove the need for the reserved memory" patchset. --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.c | 28 +++++++++++++++++++++++++ drivers/media/platform/s5p-mfc/s5p_mfc_opr.h | 4 ++++ drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 4 ++-- 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c index 34a66189d980..7f33cf23947f 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c @@ -79,6 +79,25 @@ int s5p_mfc_alloc_priv_buf(struct s5p_mfc_dev *dev, unsigned int mem_ctx, return -ENOMEM; } +int s5p_mfc_alloc_generic_buf(struct s5p_mfc_dev *dev, unsigned int mem_ctx, + struct s5p_mfc_priv_buf *b) +{ + struct device *mem_dev = dev->mem_dev[mem_ctx]; + + mfc_debug(3, "Allocating generic buf: %zu\n", b->size); + + b->ctx = mem_ctx; + b->virt = dma_alloc_coherent(mem_dev, b->size, &b->dma, GFP_KERNEL); + if (!b->virt) + goto no_mem; + + mfc_debug(3, "Allocated addr %p %pad\n", b->virt, &b->dma); + return 0; +no_mem: + mfc_err("Allocating generic buffer of size %zu failed\n", b->size); + return -ENOMEM; +} + void s5p_mfc_release_priv_buf(struct s5p_mfc_dev *dev, struct s5p_mfc_priv_buf *b) { @@ -97,3 +116,12 @@ void s5p_mfc_release_priv_buf(struct s5p_mfc_dev *dev, b->size = 0; } +void s5p_mfc_release_generic_buf(struct s5p_mfc_dev *dev, + struct s5p_mfc_priv_buf *b) +{ + struct device *mem_dev = dev->mem_dev[b->ctx]; + dma_free_coherent(mem_dev, b->size, b->virt, b->dma); + b->virt = NULL; + b->dma = 0; + b->size = 0; +} diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.h b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.h index 108e59382e0c..16d553fcff08 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.h +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.h @@ -319,6 +319,10 @@ int s5p_mfc_alloc_priv_buf(struct s5p_mfc_dev *dev, unsigned int mem_ctx, struct s5p_mfc_priv_buf *b); void s5p_mfc_release_priv_buf(struct s5p_mfc_dev *dev, struct s5p_mfc_priv_buf *b); +int s5p_mfc_alloc_generic_buf(struct s5p_mfc_dev *dev, unsigned int mem_ctx, + struct s5p_mfc_priv_buf *b); +void s5p_mfc_release_generic_buf(struct s5p_mfc_dev *dev, + struct s5p_mfc_priv_buf *b); #endif /* S5P_MFC_OPR_H_ */ diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c index 70071a12db16..85880e9106be 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c @@ -239,7 +239,7 @@ static int s5p_mfc_alloc_codec_buffers_v6(struct s5p_mfc_ctx *ctx) /* Allocate only if memory from bank 1 is necessary */ if (ctx->bank1.size > 0) { - ret = s5p_mfc_alloc_priv_buf(dev, BANK_L_CTX, &ctx->bank1); + ret = s5p_mfc_alloc_generic_buf(dev, BANK_L_CTX, &ctx->bank1); if (ret) { mfc_err("Failed to allocate Bank1 memory\n"); return ret; @@ -252,7 +252,7 @@ static int s5p_mfc_alloc_codec_buffers_v6(struct s5p_mfc_ctx *ctx) /* Release buffers allocated for codec */ static void s5p_mfc_release_codec_buffers_v6(struct s5p_mfc_ctx *ctx) { - s5p_mfc_release_priv_buf(ctx->dev, &ctx->bank1); + s5p_mfc_release_generic_buf(ctx->dev, &ctx->bank1); } /* Allocate memory for instance data buffer */