| Message ID | 1499853683-10261-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi On 2017-07-12 12:01, Andrzej Hajda wrote: > The "Fixes" patch was incorrectly merged, as a result PHY is prematurely > powered off and for example Odroid-U3 cannot disable TV power domain > when HDMI cable is unplugged. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > Fixes: 625e63e2 ("drm/exynos/hdmi: fix pipeline disable order")~ This patch finally fixes the 'Power domain TV disable failed' issue in linux-next. Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index e65cdbf..b1718d8 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -1501,8 +1501,6 @@ static void hdmi_disable(struct drm_encoder *encoder) > */ > cancel_delayed_work(&hdata->hotplug_work); > cec_notifier_set_phys_addr(hdata->notifier, CEC_PHYS_ADDR_INVALID); > - > - hdmiphy_disable(hdata); > } > > static const struct drm_encoder_helper_funcs exynos_hdmi_encoder_helper_funcs = { Best regards
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index e65cdbf..b1718d8 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1501,8 +1501,6 @@ static void hdmi_disable(struct drm_encoder *encoder) */ cancel_delayed_work(&hdata->hotplug_work); cec_notifier_set_phys_addr(hdata->notifier, CEC_PHYS_ADDR_INVALID); - - hdmiphy_disable(hdata); } static const struct drm_encoder_helper_funcs exynos_hdmi_encoder_helper_funcs = {
The "Fixes" patch was incorrectly merged, as a result PHY is prematurely powered off and for example Odroid-U3 cannot disable TV power domain when HDMI cable is unplugged. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Fixes: 625e63e2 ("drm/exynos/hdmi: fix pipeline disable order") --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 -- 1 file changed, 2 deletions(-)