From patchwork Tue Aug 16 10:45:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Perr Zhang X-Patchwork-Id: 9283299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 00800607FD for ; Tue, 16 Aug 2016 10:45:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4B191FFBD for ; Tue, 16 Aug 2016 10:45:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D945F285DE; Tue, 16 Aug 2016 10:45:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=2.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SBL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E71E285DD for ; Tue, 16 Aug 2016 10:45:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbcHPKpc (ORCPT ); Tue, 16 Aug 2016 06:45:32 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:21359 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbcHPKpa (ORCPT ); Tue, 16 Aug 2016 06:45:30 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:to:cc:message-id:subject:mime-version:content-type:user-agent; b=va1d9OUuaj5EpvShdMzJZ3yt4aSPckbJjRcidn7q8qpuNzNs6N/JaJmlkoykGK2PkZ9/FQ35zqVa EIYUgEjFX0vq60Q6KMAo8EXoe6QjpUw7R/wvrtm5OlDSnOqe4O9V Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1471344329449613.5892412981369; Tue, 16 Aug 2016 03:45:29 -0700 (PDT) Received: from [123.168.236.228] by mail.zoho.com with HTTP;Tue, 16 Aug 2016 03:45:29 -0700 (PDT) Date: Tue, 16 Aug 2016 18:45:29 +0800 From: perr perr To: "" Cc: "" , "" , "" , "" , "" , "" , "" , "" Message-ID: <15692f4c2b0.efa5c46c29252.3567074676558581477@zoho.com> Subject: [RESEND][PATCH v2] pinctrl: exynos: remove duplicate calls in irq handler MIME-Version: 1.0 X-Priority: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Because chained_irq_enter() has already called chip->irq_mask() and chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), so it's not necessary to call chip->irq_*() here. Signed-off-by: Perr Zhang Acked-by: Tomasz Figa Reviewed-by: Krzysztof Kozlowski --- drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 051b5bf..d32fa2b 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) int eint_irq; chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); generic_handle_irq(eint_irq); - chip->irq_unmask(&desc->irq_data); + chained_irq_exit(chip, desc); }