From patchwork Fri Aug 7 11:12:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 6968151 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A4D7C9F358 for ; Fri, 7 Aug 2015 11:14:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A7D85204FC for ; Fri, 7 Aug 2015 11:14:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A7432049C for ; Fri, 7 Aug 2015 11:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752715AbbHGLOD (ORCPT ); Fri, 7 Aug 2015 07:14:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51625 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbbHGLOB (ORCPT ); Fri, 7 Aug 2015 07:14:01 -0400 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NSP009VBLVBD090@mailout1.samsung.com>; Fri, 07 Aug 2015 20:13:59 +0900 (KST) X-AuditID: cbfee61b-f79706d000001b96-9b-55c492f652a1 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 1F.4C.07062.6F294C55; Fri, 7 Aug 2015 20:13:59 +0900 (KST) Received: from amdc1976.localnet ([106.120.53.102]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NSP00EM4LV9T470@mmp1.samsung.com>; Fri, 07 Aug 2015 20:13:58 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Viresh Kumar Cc: Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Krzysztof Kozlowski , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , "Rafael J. Wysocki" Subject: Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled Date: Fri, 07 Aug 2015 13:12:56 +0200 Message-id: <1594902.Dv5JKhve0y@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20150807104156.GE6939@linux> References: <1438868514-8814-1-git-send-email-b.zolnierkie@samsung.com> <5184469.cOpIkgzX4h@amdc1976> <20150807104156.GE6939@linux> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t9jAd3vk46EGlw6yWpx/ctzVov/j16z Wlz7PYPN4s3bNUwWr18YWvQuuMpm0f/4NbPF18MrGC3ePNzMaLHp8TVWi48991gtLu+aw2bx ufcIo8WM8/uYLNZtvMVucfGUq8WZ05dYLQ6/aWe16FjGaNG2+gOrxapdfxgtNn71cBDzeH+j ld3j7+xWZo+ds+6ye2xa1cnmcefaHjaPzUvqPf4dY/fY0g8U3nK1ncWjb8sqRo/t1+Yxe3ze JBfAE8Vlk5Kak1mWWqRvl8CV8eq0csF3hYqN656wNTDOke5i5OSQEDCReH1uLxuELSZx4d56 IJuLQ0hgKaNEw/MmdgjnK6PEpMY9TCBVbAJWEhPbVzF2MXJwiAhoSby8mQoSZhY4ziYx904i iC0skCVx8NksFhCbRUBV4s3PhewgNq+ApsTczd/BbFEBL4nvvxqYQWxOoDFLPnxjgdjVyiix 4HQbK0SDoMSPyfdYIBbIS+zbP5UVwtaSWL/zONMERoFZSMpmISmbhaRsASPzKkaJ1ILkguKk 9FyjvNRyveLE3OLSvHS95PzcTYzg2H0mvYPx8C73Q4wCHIxKPLwJ/w6HCrEmlhVX5h5ilOBg VhLhPVt9JFSINyWxsiq1KD++qDQntfgQozQHi5I4r77JplAhgfTEktTs1NSC1CKYLBMHp1QD o6WHyJ+NYk6ayjOk57fO+Nkbzd29QuhxWOeh11d5qgJVC0R+lQqzbuk/kleawV104vGhVw/U H5zt6G6493yZW13/j8YvU+3m5/La+R3f2SEw2/dn/aqAOzfOGgWubwkJeHx93YJwE9ulxvJL JjHwWEx/ekxZ55951VP2vMa4+SEuZ7S/rlvtqsRSnJFoqMVcVJwIAAPMdzTZAgAA Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday, August 07, 2015 04:11:56 PM Viresh Kumar wrote: > On 07-08-15, 12:34, Bartlomiej Zolnierkiewicz wrote: > > > I would suggest you sending such patches as reply to the earlier > > > threads only, instead of a new chain. This will save your time. > > > > Please explain it more. This patch needs to be first for cpufreq-dt > > switch to be complete. scaling_boost_freqs is available currently > > for exynos-cpufreq users when boost is enabled and ideally we would > > like it to be available immediately after the switch to cpufreq-dt. > > I wasn't talking about the ordering of the patches here, but when to > send patches. > > So, you now sent these patches again, but what you could have done > is: only send the first patch in reply to the earlier thread. And ask > if it looks fine. If yes, resend the whole series properly or keep > fixing there only.. > > That makes things really fast. You don't have to resend the series and > people wouldn't stay away from it. I stayed away from this series to > find enough available time to see your 6 patches. Had it been just a > reply, I would have replied immediately like now. > > Look at how updated versions in the same mail chain in case of OPP > series.. Please find updated patch below. It can be moved just before patch #6 and all patches in the series would still apply fine. ---------------------8<------------------- From 993ebb6fc632ec7b61654c9610c90ff4dca4be34 Mon Sep 17 00:00:00 2001 From: Bartlomiej Zolnierkiewicz Date: Fri, 7 Aug 2015 13:07:51 +0200 Subject: [PATCH] cpufreq-dt: make scaling_boost_freqs sysfs attr available when boost is enabled Make scaling_boost_freqs sysfs attribute is available when cpufreq-dt driver is used and boost support is enabled. Cc: Thomas Abraham Cc: Javier Martinez Canillas Cc: Krzysztof Kozlowski Suggested-by: Viresh Kumar Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Viresh Kumar --- drivers/cpufreq/cpufreq-dt.c | 11 ++++++++++- include/linux/cpufreq.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index b9259ab..c6a3b98 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -36,6 +36,12 @@ struct private_data { unsigned int voltage_tolerance; /* in percentage */ }; +static struct freq_attr *cpufreq_dt_attr[] = { + &cpufreq_freq_attr_scaling_available_freqs, + NULL, /* Extra space for boost-attr if required */ + NULL, +}; + static int set_target(struct cpufreq_policy *policy, unsigned int index) { struct dev_pm_opp *opp; @@ -182,6 +188,8 @@ try_again: return ret; } +static struct cpufreq_driver dt_cpufreq_driver; + static int cpufreq_init(struct cpufreq_policy *policy) { struct cpufreq_frequency_table *freq_table; @@ -336,6 +344,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) ret = cpufreq_enable_boost_support(); if (ret) goto out_free_cpufreq_table; + cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs; } policy->cpuinfo.transition_latency = transition_latency; @@ -411,7 +420,7 @@ static struct cpufreq_driver dt_cpufreq_driver = { .exit = cpufreq_exit, .ready = cpufreq_ready, .name = "cpufreq-dt", - .attr = cpufreq_generic_attr, + .attr = cpufreq_dt_attr, }; static int dt_cpufreq_probe(struct platform_device *pdev) diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 95f0186..657542d 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -609,6 +609,7 @@ struct cpufreq_frequency_table *cpufreq_frequency_get_table(unsigned int cpu); /* the following are really really optional */ extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs; +extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs; extern struct freq_attr *cpufreq_generic_attr[]; int cpufreq_table_validate_and_show(struct cpufreq_policy *policy, struct cpufreq_frequency_table *table);