| Message ID | 1678644516.665314-1-sleirsgoevy@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: dw_mmc: fix DW MMC cores with 32-bit bus on 64-bit Linux systems | expand |
On 12/03/2023 18:58, Sergey Lisov wrote: > Some Samsung Exynos boards using the arm64 architecture have DW MMC > controllers configured for a 32-bit data bus but a 64-bit FIFO. On these > systems the 64-bit FIFO registers must be accessed in two 32-bit halves. > > Add two new compatible strings, "samsung,exynos7885-dw-mshc" and > "samsung,exynos7885-dw-mshc-smu" respectively, to denote exynos7885 > boards that need this quirk. But it's very possible that all > "samsung,exynos7-dw-mshc" boards are actually affected. And now this is third copy of the same email. This is not acceptable. Best regards, Krzysztof
On 12/03/2023 18:58, Sergey Lisov wrote: > Some Samsung Exynos boards using the arm64 architecture have DW MMC > controllers configured for a 32-bit data bus but a 64-bit FIFO. On these > systems the 64-bit FIFO registers must be accessed in two 32-bit halves. > > Add two new compatible strings, "samsung,exynos7885-dw-mshc" and > "samsung,exynos7885-dw-mshc-smu" respectively, to denote exynos7885 > boards that need this quirk. But it's very possible that all > "samsung,exynos7-dw-mshc" boards are actually affected. > --- > .../devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml > index fdaa18481..3eebaed2c 100644 > --- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml > +++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml > @@ -22,6 +22,8 @@ properties: > - samsung,exynos5420-dw-mshc-smu > - samsung,exynos7-dw-mshc > - samsung,exynos7-dw-mshc-smu > + - samsung,exynos7885-dw-mshc > + - samsung,exynos7885-dw-mshc-smu What about the if-then at the end? Since this is pretty compatible with exynos7, then I would expect being added also there. Best regards, Krzysztof
>> + - samsung,exynos7885-dw-mshc >> + - samsung,exynos7885-dw-mshc-smu > > What about the if-then at the end? Since this is pretty compatible with > exynos7, then I would expect being added also there. Makes sense. Also it probably makes sense to add "samsung,exynos7-dw-mshc" as a fallback compatible to the jackpotlte.dts, because it probably somewhat worked for whoever contributed that.
diff --git a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml index fdaa18481..3eebaed2c 100644 --- a/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml +++ b/Documentation/devicetree/bindings/mmc/samsung,exynos-dw-mshc.yaml @@ -22,6 +22,8 @@ properties: - samsung,exynos5420-dw-mshc-smu - samsung,exynos7-dw-mshc - samsung,exynos7-dw-mshc-smu + - samsung,exynos7885-dw-mshc + - samsung,exynos7885-dw-mshc-smu - axis,artpec8-dw-mshc reg: