From patchwork Wed Jun 19 17:40:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 2751011 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DDE5D9F8E1 for ; Wed, 19 Jun 2013 17:41:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EB35B2027F for ; Wed, 19 Jun 2013 17:41:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 579A42026D for ; Wed, 19 Jun 2013 17:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934170Ab3FSRlM (ORCPT ); Wed, 19 Jun 2013 13:41:12 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:50589 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756805Ab3FSRlL (ORCPT ); Wed, 19 Jun 2013 13:41:11 -0400 Received: from cpc2-sgyl4-0-0-cust177.18-2.cable.virginmedia.com ([82.42.102.178] helo=finisterre) by cassiel.sirena.org.uk with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1UpMNE-0005mZ-Nn; Wed, 19 Jun 2013 18:40:50 +0100 Received: from broonie by finisterre with local (Exim 4.80) (envelope-from ) id 1UpMND-0008EJ-3b; Wed, 19 Jun 2013 18:40:47 +0100 Date: Wed, 19 Jun 2013 18:40:47 +0100 From: Mark Brown To: Tomasz Figa Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, alsa-devel@alsa-project.org, Kukjin Kim , Vinod Koul , Dan Williams , Linus Walleij , Alessandro Rubini , Giancarlo Asnaghi , Grant Likely , Sangbeom Kim , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Padmavathi Venna , Thomas Abraham , Arnd Bergmann , Olof Johansson , Heiko =?iso-8859-1?Q?St=FCbner?= , Sylwester Nawrocki , Russell King - ARM Linux , Alban Bedel Message-ID: <20130619174047.GB1403@sirena.org.uk> References: <1371416058-22047-1-git-send-email-tomasz.figa@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1371416058-22047-1-git-send-email-tomasz.figa@gmail.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 82.42.102.178 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Subject: Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Jun 16, 2013 at 10:54:07PM +0200, Tomasz Figa wrote: > One of the biggest roadblocks on the way of S3C64xx to DeviceTree support > is its DMA driver, which is completely platform-specific and provides > private API (s3c-dma), not even saying that its design is completely > against multiplatform-awareness. I tried to test this on my s3c64xx based system but it gave me a kernel that didn't boot far enough to give console output (there's some early init stuff that uses SPI...). That said, I needed: to get it to build which makes me suspect the compiler a bit as well... the system has audio, SPI and MMC enabled. I was applying this to -next, are there any other dependencies I need or anything? diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 210a893..0f49707 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -313,7 +313,7 @@ static int pl08x_request_mux(struct pl08x_dma_chan *plchan) int ret; if (plchan->mux_use++ == 0 && pd->get_signal) { - ret = pd->get_signal(plchan->cd); + ret = (pd->get_signal)(plchan->cd); if (ret < 0) { plchan->mux_use = 0; return ret;