From patchwork Tue Mar 29 04:19:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 8682141 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0770A9F30C for ; Tue, 29 Mar 2016 04:19:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 25BF72020F for ; Tue, 29 Mar 2016 04:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B48E201EC for ; Tue, 29 Mar 2016 04:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbcC2ET2 (ORCPT ); Tue, 29 Mar 2016 00:19:28 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35460 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbcC2ET1 (ORCPT ); Tue, 29 Mar 2016 00:19:27 -0400 Received: by mail-pa0-f42.google.com with SMTP id td3so4235924pab.2 for ; Mon, 28 Mar 2016 21:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OLKiJ2kGk22+VtqoIY9aD1XgTYvxvePlQS3avtiGlWU=; b=LZMSb+8d1HMLcf57k9asfIQNilHT45Yr0rKjRn1r2pJirEbY+QDiAAHTstxjjHg9qa pjWERe3+JVOlS5UloSvQxqC2E7y8eIJuqgDLVLplWbkx+W0p7tGd/cDyOSyJu4E4hyX8 dpA1+7MXHgbMF24NrCoXqPw9HyxNqiMBHk7m4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OLKiJ2kGk22+VtqoIY9aD1XgTYvxvePlQS3avtiGlWU=; b=Bd8lcc4YJAihoFLJz8PxSiSHt4nkjl4NfRPnupdildXzSCsnAhinNNK+XfENJTe3ti 1nDoPrCwCIZvN4s/ZiI838nee2hpvZyaEnayc2ez8FFWqnUIg4lpXlrUXx9ViTGHdlYy Feq/Y7B+NZutQQLwqBapKKl1DT91ihqhZDs4XmUiVqvv04nJpN08OtADGdm4K/E01304 y7RwfVX8NlwFuiCyLcnn6SMncwTghVBVen/DZpihtLEQES1DJMB435TSwYs+rbNy9JUV zlCWlpdvwQUjuGHWWgTBuZA9vLaiAFCg7EFEG3YXr6ENd9XKFtcGAVCuyGlGlEZri6e8 9bwQ== X-Gm-Message-State: AD7BkJJJJJjcRidrOGks/WleL81U/FPJ3WDbkPkxQYuRJwvBz6V8OEhPB2yWk96h8fRTld/k X-Received: by 10.66.141.42 with SMTP id rl10mr203911pab.48.1459225166239; Mon, 28 Mar 2016 21:19:26 -0700 (PDT) Received: from localhost ([122.167.169.132]) by smtp.gmail.com with ESMTPSA id 87sm39024333pfq.93.2016.03.28.21.19.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Mar 2016 21:19:25 -0700 (PDT) Date: Tue, 29 Mar 2016 09:49:23 +0530 From: Viresh Kumar To: Krzysztof Kozlowski Cc: Rafael Wysocki , arnd.bergmann@linaro.org, Kukjin Kim , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, kgene.kim@samsung.com, xf@rock-chips.com, heiko@sntech.de, mmcclint@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver Message-ID: <20160329041923.GB25424@vireshk-i7> References: <6cb29053bce7026dd9429326236a67c45e901c7b.1458801338.git.viresh.kumar@linaro.org> <56FA0039.6030007@samsung.com> <20160329041827.GA25424@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160329041827.GA25424@vireshk-i7> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 29-03-16, 09:48, Viresh Kumar wrote: > On 29-03-16, 13:10, Krzysztof Kozlowski wrote: > > On 24.03.2016 15:40, Viresh Kumar wrote: > > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > > > device now, reuse that and remove similar code from platform code. > > > > > > Signed-off-by: Viresh Kumar > > > --- > > > arch/arm/mach-exynos/exynos.c | 25 ------------------------- > > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++ > > > 2 files changed, 5 insertions(+), 25 deletions(-) > > > > Looks fine to me... except that it is a little bit outdated. Please > > rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. > > Yeah, I know. I already have the updated version. Here it is: From: Viresh Kumar Date: Thu, 24 Mar 2016 12:04:10 +0530 Subject: [PATCH] cpufreq: exynos: Use generic platdev driver The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform device now, reuse that and remove similar code from platform code. Signed-off-by: Viresh Kumar Reviewed-by: Krzysztof Kozlowski --- arch/arm/mach-exynos/exynos.c | 29 ----------------------------- drivers/cpufreq/cpufreq-dt-platdev.c | 9 +++++++++ 2 files changed, 9 insertions(+), 29 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index bbf51a46f772..4d3b056fd786 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -213,33 +213,6 @@ static void __init exynos_init_irq(void) exynos_map_pmu(); } -static const struct of_device_id exynos_cpufreq_matches[] = { - { .compatible = "samsung,exynos3250", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4212", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4412", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5250", .data = "cpufreq-dt" }, -#ifndef CONFIG_BL_SWITCHER - { .compatible = "samsung,exynos5420", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5800", .data = "cpufreq-dt" }, -#endif - { /* sentinel */ } -}; - -static void __init exynos_cpufreq_init(void) -{ - struct device_node *root = of_find_node_by_path("/"); - const struct of_device_id *match; - - match = of_match_node(exynos_cpufreq_matches, root); - if (!match) { - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); - return; - } - - platform_device_register_simple(match->data, -1, NULL, 0); -} - static void __init exynos_dt_machine_init(void) { /* @@ -262,8 +235,6 @@ static void __init exynos_dt_machine_init(void) of_machine_is_compatible("samsung,exynos5250")) platform_device_register(&exynos_cpuidle); - exynos_cpufreq_init(); - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index 18b81724ca0b..f85d1ab5d621 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -20,6 +20,15 @@ struct cpufreq_dt_compat { }; static struct cpufreq_dt_compat compat[] = { + { "samsung,exynos3250", NULL, 0 }, + { "samsung,exynos4210", NULL, 0 }, + { "samsung,exynos4212", NULL, 0 }, + { "samsung,exynos4412", NULL, 0 }, + { "samsung,exynos5250", NULL, 0 }, +#ifndef CONFIG_BL_SWITCHER + { "samsung,exynos5420", NULL, 0 }, + { "samsung,exynos5800", NULL, 0 }, +#endif }; static int __init cpufreq_dt_platdev_init(void)