| Message ID | 20160608183110.13851-6-matthew@mattleach.net (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 08/06/16 19:31, Matthew Leach wrote: > Fix the serial access code to deal with kernels built for big endian > operation. > > Signed-off-by: Matthew Leach <matthew@mattleach.net> > --- > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > CC: Jiri Slaby <jslaby@suse.com> > CC: linux-serial@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/tty/serial/samsung.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h > index fc5deaa..8818bdd 100644 > --- a/drivers/tty/serial/samsung.h > +++ b/drivers/tty/serial/samsung.h > @@ -118,9 +118,9 @@ struct s3c24xx_uart_port { > ((unsigned long *)(unsigned long)((port)->membase + (reg))) > > #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) > -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) > +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) > > #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) > -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) > +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) I suppose for complete-ness we should have changed the readbs as well.
On 08/06/16 19:31, Matthew Leach wrote: > Fix the serial access code to deal with kernels built for big endian > operation. > > Signed-off-by: Matthew Leach <matthew@mattleach.net> > --- > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > CC: Jiri Slaby <jslaby@suse.com> > CC: linux-serial@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/tty/serial/samsung.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h > index fc5deaa..8818bdd 100644 > --- a/drivers/tty/serial/samsung.h > +++ b/drivers/tty/serial/samsung.h > @@ -118,9 +118,9 @@ struct s3c24xx_uart_port { > ((unsigned long *)(unsigned long)((port)->membase + (reg))) > > #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) > -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) > +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) For completeness we should have changed __raw_readb to readb_relaxed > #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) > -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) > +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) Acked-by: Ben Dooks <ben.dooks@codethink.co.uk>
On 06/10/2016 12:13 PM, Ben Dooks wrote: > On 08/06/16 19:31, Matthew Leach wrote: >> Fix the serial access code to deal with kernels built for big endian >> operation. >> >> Signed-off-by: Matthew Leach <matthew@mattleach.net> >> --- >> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> CC: Jiri Slaby <jslaby@suse.com> >> CC: linux-serial@vger.kernel.org >> CC: linux-kernel@vger.kernel.org >> --- >> drivers/tty/serial/samsung.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h >> index fc5deaa..8818bdd 100644 >> --- a/drivers/tty/serial/samsung.h >> +++ b/drivers/tty/serial/samsung.h >> @@ -118,9 +118,9 @@ struct s3c24xx_uart_port { >> ((unsigned long *)(unsigned long)((port)->membase + (reg))) >> >> #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) >> -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) >> +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) > > For completeness we should have changed __raw_readb to readb_relaxed > >> #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) >> -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) >> +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) > > Acked-by: Ben Dooks <ben.dooks@codethink.co.uk> With the readb_relaced change: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h index fc5deaa..8818bdd 100644 --- a/drivers/tty/serial/samsung.h +++ b/drivers/tty/serial/samsung.h @@ -118,9 +118,9 @@ struct s3c24xx_uart_port { ((unsigned long *)(unsigned long)((port)->membase + (reg))) #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg))) -#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg))) +#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg)) -#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg)) +#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg)) #endif
Fix the serial access code to deal with kernels built for big endian operation. Signed-off-by: Matthew Leach <matthew@mattleach.net> --- CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Jiri Slaby <jslaby@suse.com> CC: linux-serial@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/tty/serial/samsung.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)