| Message ID | 20170117135441.31450-2-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hello Andi, On 01/17/2017 10:54 AM, Andi Shyti wrote: > Add binding for the STMicroelectronics FingerTip (stmfts) > touchscreen driver. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- The binding looks good to me, I've just a minor nit below. [snip] > + > +i2c@00000000 { > + > + /* ... */ > + > + stmfts@49 { The ePAPR document says: The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. So I think this should be touchscreen@49 instead. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On Tue, Jan 17, 2017 at 10:54:39PM +0900, Andi Shyti wrote: > Add binding for the STMicroelectronics FingerTip (stmfts) > touchscreen driver. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > .../bindings/input/touchscreen/st,stmfts.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > new file mode 100644 > index 000000000000..788f4ba744db > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > @@ -0,0 +1,43 @@ > +* ST-Microelectronics FingerTip touchscreen controller > + > +The ST-Microelectronics FingerTip device provides a basic touchscreen > +functionality. Along with it the user can enable the touchkey which can work as > +a basic HOME and BACK key for phones. > + > +The driver supports also hovering as an absolute single touch event with x, y, z > +coordinates. > + > +Required properties: > +- compatible : must be "st,stmfts" > +- reg : I2C slave address, (e.g. 0x49) > +- interrupt-parent : the phandle to the interrupt controller which provides > + the interrupt > +- interrupts : interrupt specification > +- avdd-supply : analogic power supply > +- vdd-supply : power supply > +- touchscreen-size-x : see touchscreen.txt > +- touchscreen-size-y : see touchscreen.txt > + > +Optional properties: > +- touch-key-connected : specifies whether the touchkey feature is connected You are making it a generic property but it is specific to this device, so: st,touch-key-connected ? > +- ledvdd-supply : power supply to the touch key leds Is this really optional? If yes... how it gets the power when not provided? Best regards, Krzysztof > + > +Example: > + > +i2c@00000000 { > + > + /* ... */ > + > + stmfts@49 { > + compatible = "st,stmfts"; > + reg = <0x49>; > + interrupt-parent = <&gpa1>; > + interrupts = <1 IRQ_TYPE_NONE>; > + touchscreen-size-x = <1599>; > + touchscreen-size-y = <2559>; > + touch-key-connected; > + avdd-supply = <&ldo30_reg>; > + vdd-supply = <&ldo31_reg>; > + ledvdd-supply = <&ldo33_reg>; > + }; > +}; > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 17, 2017 at 08:43:32PM +0200, Krzysztof Kozlowski wrote: > On Tue, Jan 17, 2017 at 10:54:39PM +0900, Andi Shyti wrote: > > Add binding for the STMicroelectronics FingerTip (stmfts) > > touchscreen driver. > > > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > > --- > > .../bindings/input/touchscreen/st,stmfts.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > > new file mode 100644 > > index 000000000000..788f4ba744db > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > > @@ -0,0 +1,43 @@ > > +* ST-Microelectronics FingerTip touchscreen controller > > + > > +The ST-Microelectronics FingerTip device provides a basic touchscreen > > +functionality. Along with it the user can enable the touchkey which can work as > > +a basic HOME and BACK key for phones. > > + > > +The driver supports also hovering as an absolute single touch event with x, y, z > > +coordinates. > > + > > +Required properties: > > +- compatible : must be "st,stmfts" > > +- reg : I2C slave address, (e.g. 0x49) > > +- interrupt-parent : the phandle to the interrupt controller which provides > > + the interrupt > > +- interrupts : interrupt specification > > +- avdd-supply : analogic power supply > > +- vdd-supply : power supply > > +- touchscreen-size-x : see touchscreen.txt > > +- touchscreen-size-y : see touchscreen.txt > > + > > +Optional properties: > > +- touch-key-connected : specifies whether the touchkey feature is connected > > You are making it a generic property but it is specific to this device, > so: > st,touch-key-connected > ? > > > +- ledvdd-supply : power supply to the touch key leds > > Is this really optional? If yes... how it gets the power when not > provided? Also, is this really a regulator? Given you are testing whether it is on or off to report LED state it feels to me it might be a GPIO pin, not regulator... Thanks.
Hi Krzysztof, > > +Optional properties: > > +- touch-key-connected : specifies whether the touchkey feature is connected > > You are making it a generic property but it is specific to this device, > so: > st,touch-key-connected > ? > > > +- ledvdd-supply : power supply to the touch key leds > > Is this really optional? If yes... how it gets the power when not > provided? yes, it is. This is required only if (st,)touch-key-connected is added, it's not required in any other case. Anyway, even if not present, the device works, just without leds, which is fine for me. Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dmitry, > > > +- ledvdd-supply : power supply to the touch key leds > > > > Is this really optional? If yes... how it gets the power when not > > provided? > > Also, is this really a regulator? Given you are testing whether it is on > or off to report LED state it feels to me it might be a GPIO pin, not > regulator... In this case it's a real regulator, not a GPIO. But even if it was a GPIO, I still could use gpio-regulator[*] which handles gpio using the regulator framework. In this case, depending on how the leds are enabled on the DTS, in the driver I would use only one api (regulators indeed) for both the cases. Thanks, Andi [*] Documentation/devicetree/bindings/regulator/gpio-regulator.txt -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 17, 2017 at 10:54:39PM +0900, Andi Shyti wrote: > Add binding for the STMicroelectronics FingerTip (stmfts) > touchscreen driver. Bindings describe h/w not drivers. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > .../bindings/input/touchscreen/st,stmfts.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > new file mode 100644 > index 000000000000..788f4ba744db > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt > @@ -0,0 +1,43 @@ > +* ST-Microelectronics FingerTip touchscreen controller > + > +The ST-Microelectronics FingerTip device provides a basic touchscreen > +functionality. Along with it the user can enable the touchkey which can work as > +a basic HOME and BACK key for phones. > + > +The driver supports also hovering as an absolute single touch event with x, y, z > +coordinates. > + > +Required properties: > +- compatible : must be "st,stmfts" Seems too generic. Is this a single device? > +- reg : I2C slave address, (e.g. 0x49) > +- interrupt-parent : the phandle to the interrupt controller which provides > + the interrupt > +- interrupts : interrupt specification > +- avdd-supply : analogic power supply > +- vdd-supply : power supply > +- touchscreen-size-x : see touchscreen.txt > +- touchscreen-size-y : see touchscreen.txt > + > +Optional properties: > +- touch-key-connected : specifies whether the touchkey feature is connected > +- ledvdd-supply : power supply to the touch key leds > + > +Example: > + > +i2c@00000000 { > + > + /* ... */ > + > + stmfts@49 { > + compatible = "st,stmfts"; > + reg = <0x49>; > + interrupt-parent = <&gpa1>; > + interrupts = <1 IRQ_TYPE_NONE>; > + touchscreen-size-x = <1599>; > + touchscreen-size-y = <2559>; > + touch-key-connected; > + avdd-supply = <&ldo30_reg>; > + vdd-supply = <&ldo31_reg>; > + ledvdd-supply = <&ldo33_reg>; > + }; > +}; > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, > > +- compatible : must be "st,stmfts" > > Seems too generic. Is this a single device? the device is precisely called ST-Microelectronics FingerTip S (stmfts). There are variants, but they all have the same name and same datasheet. Maybe I can be more specific in the description, sometimes I omitted the 'S'. Andi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 19, 2017 at 6:19 PM, Andi Shyti <andi@etezian.org> wrote: > Hi Rob, > >> > +- compatible : must be "st,stmfts" >> >> Seems too generic. Is this a single device? > > the device is precisely called ST-Microelectronics FingerTip S > (stmfts). There are variants, but they all have the same name and > same datasheet. Okay, then it is fine. > > Maybe I can be more specific in the description, sometimes I > omitted the 'S'. > > Andi > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt new file mode 100644 index 000000000000..788f4ba744db --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt @@ -0,0 +1,43 @@ +* ST-Microelectronics FingerTip touchscreen controller + +The ST-Microelectronics FingerTip device provides a basic touchscreen +functionality. Along with it the user can enable the touchkey which can work as +a basic HOME and BACK key for phones. + +The driver supports also hovering as an absolute single touch event with x, y, z +coordinates. + +Required properties: +- compatible : must be "st,stmfts" +- reg : I2C slave address, (e.g. 0x49) +- interrupt-parent : the phandle to the interrupt controller which provides + the interrupt +- interrupts : interrupt specification +- avdd-supply : analogic power supply +- vdd-supply : power supply +- touchscreen-size-x : see touchscreen.txt +- touchscreen-size-y : see touchscreen.txt + +Optional properties: +- touch-key-connected : specifies whether the touchkey feature is connected +- ledvdd-supply : power supply to the touch key leds + +Example: + +i2c@00000000 { + + /* ... */ + + stmfts@49 { + compatible = "st,stmfts"; + reg = <0x49>; + interrupt-parent = <&gpa1>; + interrupts = <1 IRQ_TYPE_NONE>; + touchscreen-size-x = <1599>; + touchscreen-size-y = <2559>; + touch-key-connected; + avdd-supply = <&ldo30_reg>; + vdd-supply = <&ldo31_reg>; + ledvdd-supply = <&ldo33_reg>; + }; +};
Add binding for the STMicroelectronics FingerTip (stmfts) touchscreen driver. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- .../bindings/input/touchscreen/st,stmfts.txt | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt