From patchwork Tue Jan 24 13:48:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Genoud X-Patchwork-Id: 9535235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F0E826042C for ; Tue, 24 Jan 2017 13:49:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DACD327FBC for ; Tue, 24 Jan 2017 13:49:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CF23F2808C; Tue, 24 Jan 2017 13:49:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 862E927FBC for ; Tue, 24 Jan 2017 13:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750860AbdAXNtC (ORCPT ); Tue, 24 Jan 2017 08:49:02 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35988 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbdAXNtA (ORCPT ); Tue, 24 Jan 2017 08:49:00 -0500 Received: by mail-lf0-f68.google.com with SMTP id h65so17353842lfi.3; Tue, 24 Jan 2017 05:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=fdcRWZpalYKj9Y3oQPheumhH4O/ejw2smaoPsfBILk8=; b=acOIs5qprOzV7JJ5GW+Z+NuE9I2BiRb2nRdCnG0Ih6jL/+W7h/h4DmX5OmAxWNuZ4j otNw+uvHQIBdNsn9d7TMQafXfsEHlSnQR6yRe1D+WLjA7kC1LqFCpJ6OPx78aiSC9QPt hIU7hWecIKmAID+Ndon0VUiDxePnVM68D8icnhta7oxuXKH1DP9cS9ltfIj0bVOAdrCw DEk9MrVMCFUIbaK/czOIH3zNk8B4y0GCzUBdWRW+1c6dRIovQiXhv51TE7s0hgub+NsU Rda/v523yChqdudLBf6H8V+Txkqyn0mUYKUDcySE5e60j9WSdBRgJKFJ5PYKQxW0+8if 7toA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fdcRWZpalYKj9Y3oQPheumhH4O/ejw2smaoPsfBILk8=; b=WWzpvLjxfAW7o6kYzZ1wiVX/xevP3+N6nfo21D+zExzHNwL6mD1p6DDB0u/u4Pkwrk SGQ+39MmvZJUPg54XpmZN4x3FGCdUlyvP0+GAP6mmORuyuhMWWF94DUlMfBxPOaVU6Y7 q379YXmvdY4GMZJj2b/kat2lI0ChS95BNRvr0idhjX/zsnQbwD1le5GcVMZRPOlCrZ/0 TRhnwfaSGC3nYPIQOzjO8vO7sl2zGKEpzjcrohXMl7WGGE1p4YgsWBNN/VSa9lC5podW nxwF5mRJEEIyG8uIZuYoEn7+qSiJOWCDSDb/SikcRqIVD+cYpw/np6cbaDJIl0ThW3Gk w3lA== X-Gm-Message-State: AIkVDXKZYkrxPQIi7TFaflQV1CLIVut8bGkv7hjyUDCF8YQhno5Uvr4HbbgvEeE7Hb4HYA== X-Received: by 10.223.150.118 with SMTP id c51mr27264518wra.190.1485265737869; Tue, 24 Jan 2017 05:48:57 -0800 (PST) Received: from localhost ([46.227.18.67]) by smtp.gmail.com with ESMTPSA id v102sm20024966wrb.11.2017.01.24.05.48.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 05:48:57 -0800 (PST) From: Richard Genoud To: Felipe Balbi , Huang Rui , Krzysztof Kozlowski , Javier Martinez Canillas , Heikki Krogerus , Kukjin Kim , devicetree@vger.kernel.org, Linux USB Mailing List , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Richard Genoud , stable@vger.kernel.org, #@vger.kernel.org, 4.4+@vger.kernel.org Subject: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports Date: Tue, 24 Jan 2017 14:48:09 +0100 Message-Id: <20170124134809.23315-1-richard.genoud@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), the USB ports on odroid-XU4 don't work anymore. Inserting an usb key (USB2.0) on the USB3.0 port result in: [ 64.488264] xhci-hcd xhci-hcd.2.auto: Port resume took longer than 20000 msec, port status = 0xc400fe3 [ 74.568156] xhci-hcd xhci-hcd.2.auto: xHCI host not responding to stop endpoint command. [ 74.574806] xhci-hcd xhci-hcd.2.auto: Assuming host is dying, halting host. [ 74.601970] xhci-hcd xhci-hcd.2.auto: HC died; cleaning up [ 74.606276] usb 3-1: USB disconnect, device number 2 [ 74.613565] usb 4-1: USB disconnect, device number 2 [ 74.621208] usb usb3-port1: couldn't allocate usb_device NB: it's not related to USB2.0 devices, I get the same result with an USB3.0 device (SATA to USB3 for instance). NB2: it doesn't happen on an odriod-XU3 board, that doesn't have the realtek RTL8153 chip. If the lines: if (dwc->revision > DWC3_REVISION_194A) reg |= DWC3_GUSB3PIPECTL_SUSPHY; are commented out, the USB3.0 start working. For a full analyse: https://lkml.org/lkml/2017/1/18/678 Felipe suggested that suspend should be disabled temporarily while what's wrong with DCW3 is figured out. Tested on Odroid XU4 Suggested-by: Felipe Balbi Tested-by: Richard Genoud Signed-off-by: Richard Genoud Cc: stable@vger.kernel.org # 4.4+ Fixes: 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores") --- arch/arm/boot/dts/exynos5422-odroidxu4.dts | 9 +++++++++ 1 file changed, 9 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts index 2faf88627a48..f62dbd9b5ad3 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts @@ -43,6 +43,15 @@ status = "okay"; }; +&usbdrd_dwc3_0 { + /* + * without that, usb devices are not recognized when + * they are plugged. + * cf: https://lkml.org/lkml/2017/1/18/678 + */ + snps,dis_u3_susphy_quirk; +}; + &usbdrd_dwc3_1 { dr_mode = "host"; };