From patchwork Thu Sep 28 13:07:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 9976047 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3BC856037E for ; Thu, 28 Sep 2017 13:08:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B31E295B9 for ; Thu, 28 Sep 2017 13:08:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F9D1295C5; Thu, 28 Sep 2017 13:08:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 967CB295B9 for ; Thu, 28 Sep 2017 13:08:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbdI1NIp (ORCPT ); Thu, 28 Sep 2017 09:08:45 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:56934 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185AbdI1NHk (ORCPT ); Thu, 28 Sep 2017 09:07:40 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20170928130738euoutp0242864848ea21b5270dadb12dea743d9c~oiGin-UYn0565305653euoutp026; Thu, 28 Sep 2017 13:07:38 +0000 (GMT) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170928130737eucas1p29d23a3093e21d2572b3115797a0cee68~oiGhxcES41162911629eucas1p29; Thu, 28 Sep 2017 13:07:37 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 6A.9F.12907.814FCC95; Thu, 28 Sep 2017 14:07:37 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170928130736eucas1p250bb9d854204ea142a2160cd9ab56194~oiGg17xjN0104501045eucas1p2J; Thu, 28 Sep 2017 13:07:36 +0000 (GMT) X-AuditID: cbfec7f1-f793a6d00000326b-ec-59ccf418d225 Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 9B.1F.20118.814FCC95; Thu, 28 Sep 2017 14:07:36 +0100 (BST) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OWZ004HER4LMZ40@eusync2.samsung.com>; Thu, 28 Sep 2017 14:07:36 +0100 (BST) From: Andrzej Hajda To: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , dri-devel@lists.freedesktop.org, Inki Dae , Rob Herring , Mark Rutland , Krzysztof Kozlowski , Chanwoo Choi , Archit Taneja , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org Subject: [RFC PATCH 3/4] extcon: add possibility to get extcon device by of node Date: Thu, 28 Sep 2017 15:07:29 +0200 Message-id: <20170928130730.8747-4-a.hajda@samsung.com> X-Mailer: git-send-email 2.14.1 In-reply-to: <20170928130730.8747-1-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHe3fO2c6k1WFeeptWMFBIyCwKX9JukHAIiejyYcKwoccLm5d2 vPZFk2bq8JrhRDELzVpLa7MlUn2Yo60U51wqNvKCHzSlNDXDobPNo99+z//5P//3feAhMbEH l5AZWbmMOkuhkvIDcPPnDceJw2uDsujlnzz0vWuIQKXlvwj0VtdNoPG1OQI9sfq0b3+X+Kh+ qhZHDscbAaqoaxcg4+wYgVx9LXykc3zioWfPNRh6bf0hQB3jTh7SfLQKLlG0odUAaFd1FY9u Lm8iaKO+gk9PaW082tReTFf36AG9ajx6nUwMiEthVBn5jPrkhTsB6VVdJpBTJincbHNhJWAh uBIISUidgdp5DcFxCBye7Ob7WUx1ADihD+Z41cfb0Xt+j7cGrwQBPv05gC/77wu4YhvA9cV/ O0l86jjcMk3sJAVRcvh7pA/zmzBqGIfDAwsCfyOQugGdLTXAzzgVDt2auZ1hERUDraX23S8d g0PTbszPQgrBnqdfef4gSC3y4UyfScCZrkDPzPIuB8IFW88uh0HXIy3ODWgBXKmxC7iiAUDv sg7jXLGw3+bceQ6jDsB6c6NPJ326CJaXiTkLDTfMBpzjy1BvfEBwO/tCN9a9oBaEtoF9ehDE 5LGZaQx7OopVZLJ5WWlRydmZRuC7iAGv7U8vWLKfswCKBNL9ovl3AzIxochnizItAJKYNEik WhiUiUUpiqJ7jDo7SZ2nYlgLCCVx6SHR+cQymZhKU+QySobJYdR7XR4plJSAiLpOkbHyFSNv 9XiFva7YrWT+7bbZ0Q13Z0ykUapn6w9WKyfzlWMNHU5ZUn1Ys7mArdOFhcZvDhSghHg6vKmx sEceAr5YTAn2ZtMRyePYuIxi1mkevYan3jKsRCzGf5iWP1Tors70vsCj3WGTpGRbeff9TaQc OZt6URIsxdl0xalITM0q/gNq3Xb/DQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsVy+t/xK7oSX85EGrQ2yFncWneO1aKp4y2r xcYZ61ktrn95zmox/whQ7MrX92wWk+5PYLE4f34Du0XnxCXsFpseX2O1uLxrDpvFjPP7mCwW LWtltlh75C67xdLrF5ksWvceYXcQ8Fgzbw2jx+W+XiaP2R0zWT02repk87jffZzJY/OSeo++ LasYPT5vkgvgiOKySUnNySxLLdK3S+DK6F23mbGgTariz4LLzA2Mr0S7GDk5JARMJH7962eB sMUkLtxbz9bFyMUhJLCEUWLTugUsEE4jk8Tx49sYQarYBDQl/m6+yQZiiwjESrw99ZkZpIhZ 4AKLxO+JM9m7GDk4hAUCJNZeVAepYRFQlbjd+pwVxOYVMJc40nSCFWKbvMS5B7eZQWxOAQuJ LQtPMYG0CgHVtFxTncDIu4CRYRWjSGppcW56brGRXnFibnFpXrpecn7uJkZgIG879nPLDsau d8GHGAU4GJV4eBccPB0pxJpYVlyZe4hRgoNZSYT3xuczkUK8KYmVValF+fFFpTmpxYcYpTlY lMR5e/esjhQSSE8sSc1OTS1ILYLJMnFwSjUwKig8YAniSKqPmxB7wOmsk3xlqGOrwu+Z2yQY mHR6mnQsH0yy3h70/4bn/dp/vQwzfCds36q+XnHLu1Urdl+IsNg+R3T6vBpDm2uSajFZt++W lj8pVb18dJLzfpGmwJDMrlMPWcsOv5hnfqxlZfWf/CbRipranjOJj9XezzcQF3iXyfVkzT1F JZbijERDLeai4kQA0wVgqGACAAA= X-CMS-MailID: 20170928130736eucas1p250bb9d854204ea142a2160cd9ab56194 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-CMS-RootMailID: 20170928130736eucas1p250bb9d854204ea142a2160cd9ab56194 X-RootMTR: 20170928130736eucas1p250bb9d854204ea142a2160cd9ab56194 References: <20170928130730.8747-1-a.hajda@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- drivers/extcon/extcon.c | 44 ++++++++++++++++++++++++++++++++++---------- include/linux/extcon.h | 6 ++++++ 2 files changed, 40 insertions(+), 10 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index cb38c2747684..fdb8c1d767c1 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1336,6 +1336,28 @@ void extcon_dev_unregister(struct extcon_dev *edev) EXPORT_SYMBOL_GPL(extcon_dev_unregister); #ifdef CONFIG_OF + +/* + * extcon_get_edev_by_of_node - Get the extcon device from devicetree. + * @node : OF node identyfying edev + * + * Return the pointer of extcon device if success or ERR_PTR(err) if fail. + */ +struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node) +{ + struct extcon_dev *edev; + + mutex_lock(&extcon_dev_list_lock); + list_for_each_entry(edev, &extcon_dev_list, entry) + if (edev->dev.parent && edev->dev.parent->of_node == node) + goto end; + edev = ERR_PTR(-EPROBE_DEFER); +end: + mutex_unlock(&extcon_dev_list_lock); + + return edev; +} + /* * extcon_get_edev_by_phandle - Get the extcon device from devicetree. * @dev : the instance to the given device @@ -1363,25 +1385,27 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) return ERR_PTR(-ENODEV); } - mutex_lock(&extcon_dev_list_lock); - list_for_each_entry(edev, &extcon_dev_list, entry) { - if (edev->dev.parent && edev->dev.parent->of_node == node) { - mutex_unlock(&extcon_dev_list_lock); - of_node_put(node); - return edev; - } - } - mutex_unlock(&extcon_dev_list_lock); + edev = extcon_get_edev_by_of_node(node); of_node_put(node); - return ERR_PTR(-EPROBE_DEFER); + return edev; } + #else + +struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node) +{ + return ERR_PTR(-ENOSYS); +} + struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) { return ERR_PTR(-ENOSYS); } + #endif /* CONFIG_OF */ + +EXPORT_SYMBOL_GPL(extcon_get_edev_by_of_node); EXPORT_SYMBOL_GPL(extcon_get_edev_by_phandle); /** diff --git a/include/linux/extcon.h b/include/linux/extcon.h index 744d60ca80c3..2f88e7491672 100644 --- a/include/linux/extcon.h +++ b/include/linux/extcon.h @@ -261,6 +261,7 @@ extern void devm_extcon_unregister_notifier_all(struct device *dev, * Following APIs get the extcon_dev from devicetree or by through extcon name. */ extern struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name); +extern struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node); extern struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index); @@ -382,6 +383,11 @@ static inline struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name) return ERR_PTR(-ENODEV); } +static inline struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node) +{ + return ERR_PTR(-ENODEV); +} + static inline struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) {